New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 676039 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Restore showing OptIn notification in M56

Project Member Reported by khmel@chromium.org, Dec 20 2016

Issue description

Inner bug: b/33746747
 

Comment 1 by khmel@chromium.org, Dec 20 2016

Cc: bhthompson@chromium.org

Comment 2 by khmel@chromium.org, Dec 20 2016

Labels: Merge-Request-56
CL: https://codereview.chromium.org/2593753002/
Cc: gkihumba@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0388f4117f0fc8c00b270bc6d477ec37d5d1c5a

commit a0388f4117f0fc8c00b270bc6d477ec37d5d1c5a
Author: khmel <khmel@chromium.org>
Date: Wed Dec 21 16:28:22 2016

arc: Add (beta) to the title of Arc OptIn notification.

This is required for M56.

BUG= 676039 
TEST=Manually on device.

Review-Url: https://codereview.chromium.org/2595633003
Cr-Commit-Position: refs/heads/master@{#440121}

[modify] https://crrev.com/a0388f4117f0fc8c00b270bc6d477ec37d5d1c5a/chrome/app/chromeos_strings.grdp

Comment 5 by dimu@chromium.org, Dec 22 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
Labels: -ReleaseBlock-Beta -Merge-Review-56 ReleaseBlock-Stable Merge-Approved-55

Comment 7 by khmel@chromium.org, Jan 12 2017

Labels: -Merge-Approved-55 Merge-Approved-56

Comment 8 by khmel@chromium.org, Jan 12 2017

Changed Merge-Approved 55 to 56 

Comment 9 by khmel@chromium.org, Jan 12 2017

Labels: -Merge-Approved-56 Merge-Merged
Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 12 2017

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea86ae7f70b6a73b81e96872b43e03eaa9ee6fc

commit 0ea86ae7f70b6a73b81e96872b43e03eaa9ee6fc
Author: khmel <khmel@chromium.org>
Date: Thu Jan 12 02:47:53 2017

[Merge M56] arc: Add (beta) to the title of Arc OptIn notification.

This is required for M56.

BUG= 676039 
TEST=Manually on device.
TBR=xiyuan@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2595633003
Cr-Commit-Position: refs/heads/master@{#440121}
(cherry picked from commit a0388f4117f0fc8c00b270bc6d477ec37d5d1c5a)

Review-Url: https://codereview.chromium.org/2629073002
Cr-Commit-Position: refs/branch-heads/2924@{#739}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/0ea86ae7f70b6a73b81e96872b43e03eaa9ee6fc/chrome/app/chromeos_strings.grdp

Cc: abod...@chromium.org rookrishna@chromium.org dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on ChromeOS 9000.66.0, 56.0.2924.67

Sign in to add a comment