New issue
Advanced search Search tips

Issue 676029 link

Starred by 2 users
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Delete Android's rezip tool

Project Member Reported by agrieve@chromium.org, Dec 20 2016 
The crazy linker requires that libchrome.so be page-aligned within the apk. To achieve this, rezip was written:

https://cs.chromium.org/chromium/src/build/android/rezip/RezipApk.java

Since that time, the functionality has been added to Android's zipalign tool via the -p flag.

The flag applies only to uncompressed libraries, and only to files that end with ".so" (so will apply only to the files that rezip targets).

There is no longer any need to have rezip.

Comment 2 by agrieve@chromium.org, Dec 21 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f43f71ff691157cd0db2725f527dc197c89685c

commit 8f43f71ff691157cd0db2725f527dc197c89685c
Author: agrieve <agrieve@chromium.org>
Date: Thu Dec 22 18:46:45 2016

Revert of Android: Delete rezip in favor of zipalign -p (patchset #1 id:1 of https://codereview.chromium.org/2594803002/ )

Reason for revert:
Broke downstream monochrome

Original issue's description:
> Android: Delete rezip in favor of zipalign -p
>
> There's no need for a custom alignment tool now that zipalign supports
> page-aligning libraries.
>
> BUG= 676029 
>
> Committed: https://crrev.com/5e7b486a42ae172313d28a6ef9c5e4bba38cd74f
> Cr-Commit-Position: refs/heads/master@{#440140}

TBR=michaelbai@chromium.org,jbudorick@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 676029 ,676589

Review-Url: https://codereview.chromium.org/2595233003
Cr-Commit-Position: refs/heads/master@{#440457}

[modify] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/BUILD.gn
[modify] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/android_webview/tools/apk_merger.py
[modify] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/build/android/gyp/apkbuilder.py
[modify] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/build/android/gyp/finalize_apk.py
[add] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/build/android/rezip/BUILD.gn
[add] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/build/android/rezip/RezipApk.java
[modify] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/build/config/android/internal_rules.gni
[modify] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/build/config/android/rules.gni
[modify] https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c/chrome/android/chrome_public_apk_tmpl.gni
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fd406f53369c1714d3587087146ff6ead4adab

commit c3fd406f53369c1714d3587087146ff6ead4adab
Author: agrieve <agrieve@chromium.org>
Date: Wed Jan 11 15:13:42 2017

Reland of Android: Delete rezip in favor of zipalign -p

There's no need for a custom alignment tool now that zipalign supports
page-aligning libraries.

Previously reverted in:
https://codereview.chromium.org/2595233003/

Reason for reland:
Contains fix for monochrome (tested merging locally).

BUG= 676029 ,676589

Review-Url: https://codereview.chromium.org/2612773005
Cr-Commit-Position: refs/heads/master@{#442906}

[modify] https://crrev.com/c3fd406f53369c1714d3587087146ff6ead4adab/BUILD.gn
[modify] https://crrev.com/c3fd406f53369c1714d3587087146ff6ead4adab/android_webview/tools/apk_merger.py
[modify] https://crrev.com/c3fd406f53369c1714d3587087146ff6ead4adab/build/android/gyp/apkbuilder.py
[modify] https://crrev.com/c3fd406f53369c1714d3587087146ff6ead4adab/build/android/gyp/finalize_apk.py
[delete] https://crrev.com/1b58a6580431b43b893e2235bbbba2f527c4a0c0/build/android/rezip/BUILD.gn
[delete] https://crrev.com/1b58a6580431b43b893e2235bbbba2f527c4a0c0/build/android/rezip/RezipApk.java
[modify] https://crrev.com/c3fd406f53369c1714d3587087146ff6ead4adab/build/config/android/internal_rules.gni
[modify] https://crrev.com/c3fd406f53369c1714d3587087146ff6ead4adab/build/config/android/rules.gni
[modify] https://crrev.com/c3fd406f53369c1714d3587087146ff6ead4adab/chrome/android/chrome_public_apk_tmpl.gni
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e55ac6b50a01574b61226ca47ca32211d81154f

commit 3e55ac6b50a01574b61226ca47ca32211d81154f
Author: agrieve <agrieve@chromium.org>
Date: Thu Jan 12 19:59:15 2017

Revert of Android: Delete rezip in favor of zipalign -p (patchset #2 id:210001 of https://codereview.chromium.org/2612773005/ )

Reason for revert:
Broke system webview merging of debug builds.

Original issue's description:
> Reland of Android: Delete rezip in favor of zipalign -p
>
> There's no need for a custom alignment tool now that zipalign supports
> page-aligning libraries.
>
> Previously reverted in:
> https://codereview.chromium.org/2595233003/
>
> Reason for reland:
> Contains fix for monochrome (tested merging locally).
>
> BUG= 676029 ,676589
>
> Review-Url: https://codereview.chromium.org/2612773005
> Cr-Commit-Position: refs/heads/master@{#442906}
> Committed: https://chromium.googlesource.com/chromium/src/+/c3fd406f53369c1714d3587087146ff6ead4adab

TBR=michaelbai@chromium.org,jbudorick@chromium.org
NOTRY=true
BUG= 676029 ,676589

Review-Url: https://codereview.chromium.org/2621353004
Cr-Commit-Position: refs/heads/master@{#443333}

[modify] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/BUILD.gn
[modify] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/android_webview/tools/apk_merger.py
[modify] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/build/android/gyp/apkbuilder.py
[modify] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/build/android/gyp/finalize_apk.py
[add] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/build/android/rezip/BUILD.gn
[add] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/build/android/rezip/RezipApk.java
[modify] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/build/config/android/internal_rules.gni
[modify] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/build/config/android/rules.gni
[modify] https://crrev.com/3e55ac6b50a01574b61226ca47ca32211d81154f/chrome/android/chrome_public_apk_tmpl.gni
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb

commit 1bb2f878c384dc07a0aca0476a3e0d51e879b2eb
Author: agrieve <agrieve@chromium.org>
Date: Mon Jan 16 13:50:14 2017

Reland #2 of Android: Delete rezip in favor of zipalign -p

There's no need for a custom alignment tool now that zipalign supports
page-aligning libraries.

Previously revert in:
https://codereview.chromium.org/2621353004/

Reason for reland:
Updated merge script to not expect gdbserver

BUG= 676029 ,676589

Review-Url: https://codereview.chromium.org/2629663003
Cr-Commit-Position: refs/heads/master@{#443886}

[modify] https://crrev.com/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb/BUILD.gn
[modify] https://crrev.com/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb/android_webview/tools/apk_merger.py
[modify] https://crrev.com/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb/build/android/gyp/apkbuilder.py
[modify] https://crrev.com/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb/build/android/gyp/finalize_apk.py
[delete] https://crrev.com/9d9e71b1d98b8a2ae88d8661cbf15ce23e6c3513/build/android/rezip/BUILD.gn
[delete] https://crrev.com/9d9e71b1d98b8a2ae88d8661cbf15ce23e6c3513/build/android/rezip/RezipApk.java
[modify] https://crrev.com/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb/build/config/android/internal_rules.gni
[modify] https://crrev.com/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb/build/config/android/rules.gni
[modify] https://crrev.com/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb/chrome/android/chrome_public_apk_tmpl.gni
►

Sign in to add a comment