New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 676022 link

Starred by 2 users
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Jan 2017
Cc:
emir...@chromium.org
█ jem456.v...@gmail.com
posciak@chromium.org
mcasas@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc

Project Member Reported by mcasas@chromium.org, Dec 20 2016 
Use GetProfileName() [0] to further explain the errors in 
gpu_video_decode_accelerator.cc, e.g. in [1], otherwise the
logs in bots when this fails looks like:

[5872:3844:1220/074819.259:ERROR:gpu_video_decode_accelerator.cc(375)] HW video decode not available for profile 11

which is not very intuitive.


[0] https://cs.chromium.org/chromium/src/media/base/video_codecs.h?sq=package:chromium&dr&rcl=1482236610&l=79
[1] https://cs.chromium.org/chromium/src/media/gpu/ipc/service/gpu_video_decode_accelerator.cc?q=gpu_video_decode_accelerator.cc&sq=package:chromium&dr&l=375

Comment 1 by jem456.v...@gmail.com, Dec 25 2016 

Hi,

If I understand correctly, should [0] also make use of GetProfileName() ?
In gpu_video_decode_accelerator.cc, other than the example you mentioned, I seem to only find [0] as another potential location where this can be used.

[0] https://cs.chromium.org/chromium/src/media/gpu/ipc/service/gpu_video_decode_accelerator.cc?q=gpu_video_decode_accelerator.cc&sq=package:chromium&dr&l=342

Comment 2 by mcasas@chromium.org, Jan 4 2017 

#1: Probably -- although I'd search around other similar files
in the same folder dumping |profile| desymbolised, e.g. [1] ?

[1] https://cs.chromium.org/chromium/src/media/gpu/android_video_decode_accelerator.cc?sq=package:chromium&dr&l=291

Comment 3 by mcasas@chromium.org, Jan 5 2017

Cc: jem456.v...@gmail.com
Owner: mcasas@chromium.org
Status: Assigned (was: Available)
Assigning to me as proxy to jem456.vasishta@gmail.com
https://codereview.chromium.org/2598313002/
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1744cf485415ad3502e20aed92f249697e8fb547

commit 1744cf485415ad3502e20aed92f249697e8fb547
Author: jem456.vasishta <jem456.vasishta@gmail.com>
Date: Sun Jan 08 11:25:15 2017

Use GetProfileName() for error logs in gpu_video_decode_accelerator.cc

BUG= 676022 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2598313002
Cr-Commit-Position: refs/heads/master@{#442180}

[modify] https://crrev.com/1744cf485415ad3502e20aed92f249697e8fb547/media/gpu/ipc/service/gpu_video_decode_accelerator.cc

Comment 5 by mcasas@chromium.org, Jan 9 2017

Status: Fixed (was: Assigned)

Comment 6 by ajha@chromium.org, Jan 10 2017 

 Issue 679361  has been merged into this issue.

Comment 7 by anatolid@chromium.org, Jan 12 2017

Labels: M-57

Comment 8 by mcasas@chromium.org, Jan 18 2017

Components: Blink>MediaRecording

Comment 9 by mcasas@chromium.org, Jan 18 2017

Components: -Blink>MediaStream>Recording
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a44ab189f977553b42b9d7706628b959289308a

commit 9a44ab189f977553b42b9d7706628b959289308a
Author: jem456.vasishta <jem456.vasishta@gmail.com>
Date: Thu Jan 19 15:26:12 2017

Use GetProfileName() for logging VideoCodecProfile strings.

BUG= 676022 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2626023003
Cr-Commit-Position: refs/heads/master@{#444738}

[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/content/renderer/media/gpu/rtc_video_decoder.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/gpu/android_video_encode_accelerator.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/gpu/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/gpu/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/gpu/video_encode_accelerator_unittest.cc
[modify] https://crrev.com/9a44ab189f977553b42b9d7706628b959289308a/media/gpu/vt_video_encode_accelerator_mac.cc
►

Sign in to add a comment