New issue
Advanced search Search tips

Issue 676012 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

webkitpy: Refactor and simplify now that we can assume SVN is not used.

Project Member Reported by qyears...@chromium.org, Dec 20 2016 
Since the Blink codebase is merged into Chromium and Chromium is git-only now, we can simplify SCM-related code in webkitpy, which will make the code easier to work with in the future.

Comment 1 by qyears...@chromium.org, Dec 21 2016

Owner: qyears...@chromium.org
Status: Started (was: Available)
Initial CL: https://codereview.chromium.org/2594513003

Comment 2 by qyears...@chromium.org, Dec 21 2016

Summary: webkitpy: Refactor and simplify now that we can assume SVN is not used. (was: webkitpy: Refactor: Merge scm.py and git.py.)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad16c9d3694d24a3ed6c1eab71a567d1094d99f7

commit ad16c9d3694d24a3ed6c1eab71a567d1094d99f7
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Jan 09 18:09:18 2017

Merge scm.py and git.py in webkitpy.

This is something which I've wanted to do for a while,
since the Blink codebase is merged into Chromium and
Chromium is git-only.

The purpose of this change is to make it a little simpler
and easier to change or use SCM methods in webkitpy in
the future.

In this CL:
 - Remove scm.py, merge scm.py and git.py
 - Move scm_mock.py -> git_mock.py
 - Move scm_unittest.py -> git_unittest.py
 - Simplify git.py, git_mock.py.
 - Clean up and improve coverage for git_unittest.py.

Follow-ups that I think should be done after this:
 - Remove SCM detection code.
 - Rename scm -> git everywhere.
 - Move git.py and unit test into webkitpy/common/.
 - Refactor SCM initialization code in Host.
 - Move Windows-only git initialization from Host.

BUG= 676012 

Review-Url: https://codereview.chromium.org/2594513003
Cr-Commit-Position: refs/heads/master@{#442291}

[modify] https://crrev.com/ad16c9d3694d24a3ed6c1eab71a567d1094d99f7/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[rename] https://crrev.com/ad16c9d3694d24a3ed6c1eab71a567d1094d99f7/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git_mock.py
[add] https://crrev.com/ad16c9d3694d24a3ed6c1eab71a567d1094d99f7/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git_unittest.py
[delete] https://crrev.com/f115664eb4b48daa35590c365d7db577f3514c0c/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
[delete] https://crrev.com/f115664eb4b48daa35590c365d7db577f3514c0c/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
[modify] https://crrev.com/ad16c9d3694d24a3ed6c1eab71a567d1094d99f7/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d097cd3bbd127ea8168b7d399ab25404b9701b15

commit d097cd3bbd127ea8168b7d399ab25404b9701b15
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Jan 16 00:19:46 2017

Follow-up fix to Git module.

After http://crrev.com/2594513003, the git.changed_files function was
broken, which broke webkit-patch pretty-diff.

BUG= 676012 , 680839 

Review-Url: https://codereview.chromium.org/2636453005
Cr-Commit-Position: refs/heads/master@{#443824}

[modify] https://crrev.com/d097cd3bbd127ea8168b7d399ab25404b9701b15/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7091f37e5b763d57e4752a4e69cf46719b8ea1c4

commit 7091f37e5b763d57e4752a4e69cf46719b8ea1c4
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Feb 01 19:44:30 2017

Simplify the initialization of Git objects in Host.

This CL makes calling Host.initialize_scm() unnecessary by making
it so that the Git object is initialized when required. It also
merges scm() and scm_for_path(), and moves initialization logic
into the Git class.

BUG= 676012 

Review-Url: https://codereview.chromium.org/2663623003
Cr-Commit-Position: refs/heads/master@{#447582}

[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git_mock.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/style/main.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/7091f37e5b763d57e4752a4e69cf46719b8ea1c4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cd1e0590f82ef11669abfbf00d846d759235460

commit 6cd1e0590f82ef11669abfbf00d846d759235460
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Feb 02 00:09:45 2017

Revert of Simplify the initialization of Git objects in Host. (patchset #3 id:40001 of https://codereview.chromium.org/2663623003/ )

Reason for revert:
Speculative revert. This might be the cause of build flakiness, see crbug.com/687707

Original issue's description:
> Simplify the initialization of Git objects in Host.
>
> This CL makes calling Host.initialize_scm() unnecessary by making
> it so that the Git object is initialized when required. It also
> merges scm() and scm_for_path(), and moves initialization logic
> into the Git class.
>
> BUG= 676012 
>
> Review-Url: https://codereview.chromium.org/2663623003
> Cr-Commit-Position: refs/heads/master@{#447582}
> Committed: https://chromium.googlesource.com/chromium/src/+/7091f37e5b763d57e4752a4e69cf46719b8ea1c4

TBR=jeffcarp@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 676012 

Review-Url: https://codereview.chromium.org/2671583002
Cr-Commit-Position: refs/heads/master@{#447650}

[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git_mock.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/style/main.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188

commit d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Feb 06 00:37:02 2017

Reland of Simplify the initialization of Git objects in Host. (patchset #1 id:1 of https://codereview.chromium.org/2671583002/ )

Reason for revert:
Reverting speculative revert; the flaky failure on Mac was unrelated to this CL.

Original issue's description:
> Revert of Simplify the initialization of Git objects in Host. (patchset #3 id:40001 of https://codereview.chromium.org/2663623003/ )
>
> Reason for revert:
> Speculative revert. This might be the cause of build flakiness, see crbug.com/687707
>
> Original issue's description:
> > Simplify the initialization of Git objects in Host.
> >
> > This CL makes calling Host.initialize_scm() unnecessary by making
> > it so that the Git object is initialized when required. It also
> > merges scm() and scm_for_path(), and moves initialization logic
> > into the Git class.
> >
> > BUG= 676012 
> >
> > Review-Url: https://codereview.chromium.org/2663623003
> > Cr-Commit-Position: refs/heads/master@{#447582}
> > Committed: https://chromium.googlesource.com/chromium/src/+/7091f37e5b763d57e4752a4e69cf46719b8ea1c4
>
> TBR=jeffcarp@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 676012 
>
> Review-Url: https://codereview.chromium.org/2671583002
> Cr-Commit-Position: refs/heads/master@{#447650}
> Committed: https://chromium.googlesource.com/chromium/src/+/6cd1e0590f82ef11669abfbf00d846d759235460

TBR=jeffcarp@chromium.org,lushnikov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 676012 

Review-Url: https://codereview.chromium.org/2676673006
Cr-Commit-Position: refs/heads/master@{#448196}

[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git_mock.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/style/main.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f8000d3c94992dd5ad03537b73d97b7d514169e

commit 8f8000d3c94992dd5ad03537b73d97b7d514169e
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Feb 08 00:29:58 2017

Move webkitpy/common/checkout/scm/* -> webkitpy/common/checkout/.

BUG= 676012 

Review-Url: https://codereview.chromium.org/2680173002
Cr-Commit-Position: refs/heads/master@{#448817}

[rename] https://crrev.com/8f8000d3c94992dd5ad03537b73d97b7d514169e/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
[rename] https://crrev.com/8f8000d3c94992dd5ad03537b73d97b7d514169e/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_mock.py
[rename] https://crrev.com/8f8000d3c94992dd5ad03537b73d97b7d514169e/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py
[delete] https://crrev.com/a3d72e6945823292c6fa7487268333b538b6a10e/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py
[modify] https://crrev.com/8f8000d3c94992dd5ad03537b73d97b7d514169e/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/8f8000d3c94992dd5ad03537b73d97b7d514169e/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[modify] https://crrev.com/8f8000d3c94992dd5ad03537b73d97b7d514169e/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
[modify] https://crrev.com/8f8000d3c94992dd5ad03537b73d97b7d514169e/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f811f2f382ccdc9b5375c14cb8761c0a0257575

commit 3f811f2f382ccdc9b5375c14cb8761c0a0257575
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Feb 09 16:42:34 2017

Rename Host.scm -> Host.git.

BUG= 676012 

Review-Url: https://codereview.chromium.org/2679173005
Cr-Commit-Position: refs/heads/master@{#449313}

[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/style/main.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/style/main_unittest.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/3f811f2f382ccdc9b5375c14cb8761c0a0257575/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Comment 10 by qyears...@chromium.org, Feb 10 2017 

This is now almost done, but there is still code that can be simplified in:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py

Comment 12 by qyears...@chromium.org, Mar 19 2017

Labels: -Type-Bug Type-Task
One more thing that should be done before this is considered complete: Fix other things that mention svn (including .svn) in these files:

  style/checkers/png.py
  style/checkers/cpp.py
  style/checkers/cpp.py
  common/checkout/git.py
  common/find_files.py
  common/webkit_finder.py
  common/host.py
  layout_tests/port/base.py
  bindings/bindings_tests.py
  performance_tests/perftestsrunner.py
  tool/servers/reflection_handler_unittest.py
  tool/commands/auto_rebaseline.py
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9af474c03151485e6fc051804996b996371bc94

commit b9af474c03151485e6fc051804996b996371bc94
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Apr 10 19:36:34 2017

Remove remaining references to SVN.

BUG= 676012 

Review-Url: https://codereview.chromium.org/2801393002
Cr-Commit-Position: refs/heads/master@{#463364}

[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline.py
[modify] https://crrev.com/b9af474c03151485e6fc051804996b996371bc94/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py

Comment 14 by qyears...@chromium.org, Apr 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment