InputEvent: Move |Editor::appliedEditing()| to |CompositeEditCommand::appliedEditing()| |
|||
Issue descriptionAccording yosin@'s suggestion on editing code re-factoring, we should keep |Editor| class simple and move all the complex logic into |CompositeEditCommand|. Currently we are firing 'input' event inside |Editor::appliedEditing()|, after the move we could fire 'input' event only in "CompositeEditCommand.cpp".
,
Mar 15 2017
,
Jan 11 2018
Un-assigning myself as I no longer work on InputEvent.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/099eef98bfd425d0ca08d5927831a242120c0b51 commit 099eef98bfd425d0ca08d5927831a242120c0b51 Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Fri Mar 02 05:15:00 2018 Move *AppliedEditing() out of |Editor|. Move AppliedEditing() to CompositeEditCommand. Move UnappliedEditing() and ReappliedEditing() to UndoStep. Move some related local functions to EditingCommandsUtilities. This CL makes |Editor| class simple for improving code health. Bug: 672405, 676001 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ia49f52490ec41292cd46ea136d0ae11a05c9e6ae Reviewed-on: https://chromium-review.googlesource.com/930064 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540451} [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/Editor.h [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/commands/EditingCommandsUtilities.cpp [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/commands/EditingCommandsUtilities.h [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp [modify] https://crrev.com/099eef98bfd425d0ca08d5927831a242120c0b51/third_party/WebKit/Source/core/editing/commands/UndoStep.cpp |
|||
►
Sign in to add a comment |
|||
Comment 1 by chongz@chromium.org
, Mar 15 2017