New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675997 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature


Sign in to add a comment

Run angle_perftests on more platforms

Project Member Reported by jmad...@chromium.org, Dec 20 2016

Issue description

The tests currently run Windows-only. It would be good to have other platforms (Linux, Android, etc).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b8a580a3b2d66ebbf43c7c1c9be703d3af432e4b

commit b8a580a3b2d66ebbf43c7c1c9be703d3af432e4b
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Dec 21 19:14:20 2016

Enable building angle_perftests on Linux.

BUG=chromium:675997

Change-Id: I3058892b80ccf61664d023419651fd4aa1dfec2a
Reviewed-on: https://chromium-review.googlesource.com/423111
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/b8a580a3b2d66ebbf43c7c1c9be703d3af432e4b/src/tests/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b8a580a3b2d66ebbf43c7c1c9be703d3af432e4b

commit b8a580a3b2d66ebbf43c7c1c9be703d3af432e4b
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Dec 21 19:14:20 2016

Enable building angle_perftests on Linux.

BUG=chromium:675997

Change-Id: I3058892b80ccf61664d023419651fd4aa1dfec2a
Reviewed-on: https://chromium-review.googlesource.com/423111
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/b8a580a3b2d66ebbf43c7c1c9be703d3af432e4b/src/tests/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/406e37b38ab86429ce67bd26b37f959a38a0f0d4

commit 406e37b38ab86429ce67bd26b37f959a38a0f0d4
Author: cwallez <cwallez@chromium.org>
Date: Thu Dec 22 14:53:03 2016

Roll ANGLE d901983..b8a580a

https://chromium.googlesource.com/angle/angle.git/+log/d901983..b8a580a

BUG= 676333 ,chromium:675997, chromium:676217 ,None,chromium:675819

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2592213002
Cr-Commit-Position: refs/heads/master@{#440415}

[modify] https://crrev.com/406e37b38ab86429ce67bd26b37f959a38a0f0d4/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35b4553e325411865edb3873181869ea330a91d2

commit 35b4553e325411865edb3873181869ea330a91d2
Author: jmadill <jmadill@chromium.org>
Date: Mon Jan 09 21:43:16 2017

Roll ANGLE a66779f..037340d

https://chromium.googlesource.com/angle/angle.git/+log/a66779f..037340d

BUG=chromium:675997, chromium:630498 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2621683003
Cr-Commit-Position: refs/heads/master@{#442361}

[modify] https://crrev.com/35b4553e325411865edb3873181869ea330a91d2/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecbaf9756e7cc6f7e4743a614a32ff2e6c3ed2a9

commit ecbaf9756e7cc6f7e4743a614a32ff2e6c3ed2a9
Author: jmadill <jmadill@chromium.org>
Date: Tue Jan 10 16:21:49 2017

Run angle_perftests on the GPU FYI bots.

This will help safeguard against future breakage, and be a place to
test the tests before we add them to other bots.

BUG=675997
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2591813002
Cr-Commit-Position: refs/heads/master@{#442605}

[modify] https://crrev.com/ecbaf9756e7cc6f7e4743a614a32ff2e6c3ed2a9/chrome/test/BUILD.gn
[modify] https://crrev.com/ecbaf9756e7cc6f7e4743a614a32ff2e6c3ed2a9/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/ecbaf9756e7cc6f7e4743a614a32ff2e6c3ed2a9/testing/buildbot/chromium.gpu.fyi.json

Blockedon: 704211
Cc: jmad...@chromium.org
Owner: ynovikov@chromium.org
Status: Assigned (was: Started)
Yuly was looking at adding this for Android.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/359487c822bbc119e8c12f0991b9fef37dc3caff

commit 359487c822bbc119e8c12f0991b9fef37dc3caff
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Sat Oct 07 04:01:39 2017

Build angle_perftests on Android

BUG=chromium:675997

Change-Id: Ib6690f9f25a4ba4510cf6e18ba2054a9936dc574
Reviewed-on: https://chromium-review.googlesource.com/706455
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/359487c822bbc119e8c12f0991b9fef37dc3caff/src/tests/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 7 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/b99a918e92584451675f1a5fbdd24a4e77a35e31

commit b99a918e92584451675f1a5fbdd24a4e77a35e31
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Sat Oct 07 05:32:10 2017

Roll skia/third_party/externals/angle2/ a3d384ada..359487c82 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/a3d384ada3dc..359487c822bb

$ git log a3d384ada..359487c82 --date=short --no-merges --format='%ad %ae %s'
2017-10-03 ynovikov Build angle_perftests on Android

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=675997


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=scroggo@google.com

Change-Id: I7965662576fa4bb32ea183bab8bf6b5b5cc09015
Reviewed-on: https://skia-review.googlesource.com/56960
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/b99a918e92584451675f1a5fbdd24a4e77a35e31/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f935870541d4cf5f4d605e1e2db50e067d752eee

commit f935870541d4cf5f4d605e1e2db50e067d752eee
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Sat Oct 07 06:46:47 2017

Roll src/third_party/skia/ cc604e5e9..b99a918e9 (1 commit)

https://skia.googlesource.com/skia.git/+log/cc604e5e9e33..b99a918e9258

$ git log cc604e5e9..b99a918e9 --date=short --no-merges --format='%ad %ae %s'
2017-10-07 angle-deps-roller Roll skia/third_party/externals/angle2/ a3d384ada..359487c82 (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG=675997


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ib931a3a183147782aaf0b6332096345be4cde37e
Reviewed-on: https://chromium-review.googlesource.com/706696
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507287}
[modify] https://crrev.com/f935870541d4cf5f4d605e1e2db50e067d752eee/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df36684e0b2cc8c8e2004fe738ee798b58559511

commit df36684e0b2cc8c8e2004fe738ee798b58559511
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Oct 10 18:16:14 2017

Roll ANGLE 000dab8..af5070f

https://chromium.googlesource.com/angle/angle.git/+log/000dab8..af5070f

BUG=chromium:675997, chromium:743136 , chromium:735497 

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I12dc98d7721a04f3e3ff45dff571f4f297bff695
Reviewed-on: https://chromium-review.googlesource.com/709468
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507721}
[modify] https://crrev.com/df36684e0b2cc8c8e2004fe738ee798b58559511/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd40db1f78feb7627969f3d0f21db49239bef771

commit bd40db1f78feb7627969f3d0f21db49239bef771
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Tue Oct 10 20:25:44 2017

Build angle_perftests on Android

BUG=675997

Change-Id: I17be5ebf8bab18629433d5c7fa182022175c2626
Reviewed-on: https://chromium-review.googlesource.com/706456
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507757}
[modify] https://crrev.com/bd40db1f78feb7627969f3d0f21db49239bef771/chrome/test/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ec6bbca6703aac20dc98d0386f695f5f7a24baa

commit 1ec6bbca6703aac20dc98d0386f695f5f7a24baa
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Sat Oct 14 22:14:33 2017

Run angle_perftests on Nexus 5X GPU.FYI

BUG=675997

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic11a464f6308e8aef879bd96d074c4010296791c
Reviewed-on: https://chromium-review.googlesource.com/717740
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508942}
[modify] https://crrev.com/1ec6bbca6703aac20dc98d0386f695f5f7a24baa/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/1ec6bbca6703aac20dc98d0386f695f5f7a24baa/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d96e9f9754fd98ac8d3cecbedc5b1aebf2549dc

commit 5d96e9f9754fd98ac8d3cecbedc5b1aebf2549dc
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Oct 25 23:33:29 2017

Run angle_perftests on all Android GPU.FYI

Was previously enabled only on Nexus 5X.
Want to run them on several bots in Perf waterfall.

BUG=675997
TEST=Ran on Nexus 7 Android L and Pixel C Android O locally.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic7e89c6a90b4f053828802f02e9004827e5bbda9
Reviewed-on: https://chromium-review.googlesource.com/737253
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511644}
[modify] https://crrev.com/5d96e9f9754fd98ac8d3cecbedc5b1aebf2549dc/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/5d96e9f9754fd98ac8d3cecbedc5b1aebf2549dc/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d9c729f69bc5afaa31b90799d3dac6741301d5

commit 38d9c729f69bc5afaa31b90799d3dac6741301d5
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Oct 26 01:43:57 2017

Revert "Run angle_perftests on all Android GPU.FYI"

This reverts commit 5d96e9f9754fd98ac8d3cecbedc5b1aebf2549dc.

Reason for revert: fails to run on non-swarmed bots

Original change's description:
> Run angle_perftests on all Android GPU.FYI
> 
> Was previously enabled only on Nexus 5X.
> Want to run them on several bots in Perf waterfall.
> 
> BUG=675997
> TEST=Ran on Nexus 7 Android L and Pixel C Android O locally.
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ic7e89c6a90b4f053828802f02e9004827e5bbda9
> Reviewed-on: https://chromium-review.googlesource.com/737253
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511644}

TBR=ynovikov@chromium.org,jmadill@chromium.org,kbr@chromium.org

Change-Id: I6de41c621919ec703f3f2a2991bafaca15397fdf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 675997
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/738334
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511688}
[modify] https://crrev.com/38d9c729f69bc5afaa31b90799d3dac6741301d5/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/38d9c729f69bc5afaa31b90799d3dac6741301d5/testing/buildbot/chromium.gpu.fyi.json

Comment 16 by kbr@chromium.org, Oct 26 2017

On https://chromium-review.googlesource.com/737253 Yuly asked:

> Any idea why this didn't work?
> It runs successfully on swarmed, but fails on non-swarmed.
> I thought it would work in the same way as angle_unittests, but looks like it's
> different, because unittests are in COMMON_GTESTS but perftests are in
> NON_TELEMETRY_ISOLATED_SCRIPT_TESTS.
> What do I need to change to make it work?

Comparing a working run on the Swarmed Nexus 5X bot:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FAndroid_Release__Nexus_5X_%2F12518%2F%2B%2Frecipes%2Fsteps%2Fangle_perftests_on_Android%2F0%2Fstdout

to a failing run on the non-swarmed Nexus 6P bot:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FAndroid_Release__Nexus_6P_%2F8577%2F%2B%2Frecipes%2Fsteps%2Fangle_perftests%2F0%2Fstdout

the isolate was successfully downloaded and began to run. The problem seems to be that device setup failed. The first failure in the log compared to the 5X bot was:

I   36.230s TimeoutThread-3-for-prepare_device(84B7N15B05003894)  [host]> /b/c/b/Android_Release__Nexus_6P_/ir/third_party/android_tools/sdk/platform-tools/adb -s 84B7N15B05003894 shell '( pm path android );echo %$?'
D   36.242s TimeoutThread-1-for-delete_temporary_file(84B7N15B05003894)  STDOUT+STDERR: 
D   36.294s TimeoutThread-3-for-prepare_device(84B7N15B05003894)  STDOUT+STDERR: 
W   36.295s TimeoutThread-3-for-prepare_device(84B7N15B05003894)  exit status of shell command 'pm path android' missing.
I   36.295s TimeoutThread-3-for-prepare_device(84B7N15B05003894)  condition 'pm_ready' not met (23.3s)
D   38.574s TimeoutThread-2-for-delete_temporary_file(84B7N15B05003894)  STDOUT+STDERR: error: unknown host service


I don't know what this means; jbudorick@ might.

However -- I think the best solution at this point would be to move all of these Android devices into the Chrome-GPU Swarming pool. Then they would work identically to the Swarmed Nexus 5X bot. I think that we could adjust shard timeouts to allow the really long-running tests to complete.

Would you be interested in doing this? We could start with one of the bots, say the Nexus 6 or 6P (one which isn't absolutely critical). What would be needed is:
 - Ask the Labs team to provision a new Linux VM which will become the new "Android Release (Nexus 6P)" bot (for example)
 - Change tools/build/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py to make the bot match the configuration of "Android Release (Nexus 5X)", namely:
   - 'enable_swarming': True,
   - Remove this line to look like the 5X bot:
     - 'android_apply_config': ['restart_usb', 'use_devil_adb'],

(Note: the android_apply_config line might actually be the problem...it's definitely a configuration difference between the Swarmed and non-Swarmed bot.)

Then:
 - Modify configs/chromium-swarm/bots.cfg per:
https://www.chromium.org/developers/testing/gpu-testing/gpu-bot-details#TOC-Relevant-files-that-control-the-operation-of-the-GPU-bots
   to assign the existing 6P (for example) bot into the Chrome-GPU pool.
 - Ask the Labs team to put the 6P bot into Swarming.
 - Modify generate_buildbot_json.py to use Swarming on this bot.

We will definitely need to adjust shard timeouts since we'll have only one bot. We could also ask the Labs team about provisioning more devices, but that would take longer.

Let me know what you think.

Blockedon: 778771
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b8d2664fe9effff309c1053da9b79511e6f1fe4f

commit b8d2664fe9effff309c1053da9b79511e6f1fe4f
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Nov 02 02:30:47 2017

Run angle_perftests on GLES backend

Adds OPENGLES_NULL configuration
and selects between OPENGL and OPENGLES based on whether building for Android.

Also 2 small changes to get the newly enabled tests to pass on N5X:
1. Require GL_EXT_texture_storage in TexSubImage test
2. Limit numVertexUniforms and numFragmentUniforms to 64 in MatrixUniforms test

BUG=675997
Change-Id: I5439e5fb7e93b3a928f12594761115d56f60d81b
Reviewed-on: https://chromium-review.googlesource.com/748522
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/DrawCallPerf.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/DrawElementsPerf.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/DrawCallPerfParams.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/TextureSampling.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/InterleavedAttributeData.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/LinkProgramPerfTest.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/InstancingPerf.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/BindingPerf.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/test_utils/angle_test_configs.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/PointSprites.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/DrawCallPerfParams.h
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/BufferSubData.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/UniformsPerf.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/TexSubImage.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/MultiviewPerf.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/perf_tests/TexturesPerf.cpp
[modify] https://crrev.com/b8d2664fe9effff309c1053da9b79511e6f1fe4f/src/tests/test_utils/angle_test_configs.h

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ba6e99f6704864d2026c17f4a44795d7fb57e61c

commit ba6e99f6704864d2026c17f4a44795d7fb57e61c
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Nov 02 03:25:50 2017

Roll skia/third_party/externals/angle2/ 526543cb0..b8d2664fe (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/526543cb0065..b8d2664fe9ef

$ git log 526543cb0..b8d2664fe --date=short --no-merges --format='%ad %ae %s'
2017-10-27 ynovikov Run angle_perftests on GLES backend

Created with:
  roll-dep skia/third_party/externals/angle2
BUG=675997


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=stani@google.com

Change-Id: I648edc8839acd069e4ad4612118bdc9659e44fd4
Reviewed-on: https://skia-review.googlesource.com/66623
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/ba6e99f6704864d2026c17f4a44795d7fb57e61c/DEPS

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd7540f81bf138e1524f005744a26d0c86bd79a

commit 2cd7540f81bf138e1524f005744a26d0c86bd79a
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Nov 02 07:17:49 2017

Roll src/third_party/skia/ a2022cf4d..2c35c8831 (2 commits)

https://skia.googlesource.com/skia.git/+log/a2022cf4d6a2..2c35c88315a1

$ git log a2022cf4d..2c35c8831 --date=short --no-merges --format='%ad %ae %s'
2017-11-02 angle-deps-roller Roll skia/third_party/externals/angle2/ b8d2664fe..4ef250333 (2 commits)
2017-11-02 angle-deps-roller Roll skia/third_party/externals/angle2/ 526543cb0..b8d2664fe (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG=675997


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I462d8a847fcacc7f721c3029f6e27027941cd530
Reviewed-on: https://chromium-review.googlesource.com/749970
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513415}
[modify] https://crrev.com/2cd7540f81bf138e1524f005744a26d0c86bd79a/DEPS

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09ce14c7d3c8ef1dd4e7e32fc1ed043b703d8da9

commit 09ce14c7d3c8ef1dd4e7e32fc1ed043b703d8da9
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 03 05:32:24 2017

Roll src/third_party/angle/ 63458a3ed..7b62cf97d (24 commits)

https://chromium.googlesource.com/angle/angle.git/+log/63458a3ed819..7b62cf97d12b

$ git log 63458a3ed..7b62cf97d --date=short --no-merges --format='%ad %ae %s'
2017-11-02 jmadill Refactor TextureFormatMap to store an array.
2017-11-02 jmadill Add missing reset to GL multi-view dirty bits.
2017-11-02 jmadill Use active textures mask with robust init.
2017-11-02 jmadill Vulkan: Refactor format table.
2017-11-02 oetuaho Remove repeated "success" check from compileTreeImpl
2017-10-27 jie.a.chen ES31 program query: support AtomicCounterBuffer and UniformBlock
2017-11-02 jmadill Add a meta-script to run code generators.
2017-10-27 geofflang Pass offsets to base validation for CompressedSubTexImage3D.
2017-10-28 jmadill Vulkan: Add vk::GetImpl helper.
2017-10-28 jmadill Vulkan: Allow in-flight Framebuffer changes.
2017-11-02 oetuaho Add missing check in Compiler
2017-11-01 jie.a.chen Refactor StaticallyUsed
2017-09-27 geofflang Make GL_OES_get_program_binary enableable.
2017-10-27 ynovikov Run angle_perftests on GLES backend
2017-10-28 jmadill Vulkan: Fix deleting in-use Framebuffer.
2017-10-30 geofflang Make compressed texture format extensions enableable.
2017-11-01 jmadill Vulkan: Support Texture redefinition.
2017-10-30 geofflang Make ANGLE_texture_usage enableable.
2017-10-28 jmadill Vulkan: Fix re-creating buffer storage.
2017-10-28 jmadill Introduce SimpleStateChangeTests.
2017-10-28 jmadill Remove WrappedObject::retain.
2017-10-30 geofflang Fix minor issues with ANGLE_texture_rectangle.
2017-10-30 cwallez preprocessor: Fix lineno overflow on line continuations
2017-11-01 geofflang Revert BGRA renderability change for ES drivers.

Created with:
  roll-dep src/third_party/angle
BUG= 780545 ,675997, 774807 , 779346 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ic633a311ad465c126e473a2c38704b034c7e799d
Reviewed-on: https://chromium-review.googlesource.com/752511
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513699}
[modify] https://crrev.com/09ce14c7d3c8ef1dd4e7e32fc1ed043b703d8da9/DEPS

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e88b6df1f70af8a53be62fc6df7f325e71d5fc10

commit e88b6df1f70af8a53be62fc6df7f325e71d5fc10
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Nov 03 05:49:39 2017

Run angle_perftests on Nexus 6P GPU.FYI

BUG=675997

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I70d5943d72432828b5ed0fe9d94c9968a9c831fb
Reviewed-on: https://chromium-review.googlesource.com/752346
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513705}
[modify] https://crrev.com/e88b6df1f70af8a53be62fc6df7f325e71d5fc10/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/e88b6df1f70af8a53be62fc6df7f325e71d5fc10/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46aa3c2546addfe0ff5dcb663b97ccef345404ec

commit 46aa3c2546addfe0ff5dcb663b97ccef345404ec
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Nov 10 06:15:29 2017

Run angle_perftests on Nexus 5X Perf bot

Also build angle_perftests on Android builders

BUG=675997
TBR=eyaich@chromium.org,dpranke@chromium.org

Change-Id: I9e73e19599e3cc435f02960839f2e780402d0188
Reviewed-on: https://chromium-review.googlesource.com/752582
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515462}
[modify] https://crrev.com/46aa3c2546addfe0ff5dcb663b97ccef345404ec/BUILD.gn
[modify] https://crrev.com/46aa3c2546addfe0ff5dcb663b97ccef345404ec/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/46aa3c2546addfe0ff5dcb663b97ccef345404ec/tools/perf/core/perf_data_generator.py

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beec1c5a10abc829eb9719bc8fb1f1bfc4c4a90f

commit beec1c5a10abc829eb9719bc8fb1f1bfc4c4a90f
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Nov 10 20:14:35 2017

Revert "Run angle_perftests on Nexus 5X Perf bot"

This reverts commit 46aa3c2546addfe0ff5dcb663b97ccef345404ec.

Reason for revert: this is failing (https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus5X%20Perf/builds/775)

Original change's description:
> Run angle_perftests on Nexus 5X Perf bot
> 
> Also build angle_perftests on Android builders
> 
> BUG=675997
> TBR=eyaich@chromium.org,dpranke@chromium.org
> 
> Change-Id: I9e73e19599e3cc435f02960839f2e780402d0188
> Reviewed-on: https://chromium-review.googlesource.com/752582
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515462}

TBR=dtu@chromium.org,ynovikov@chromium.org,dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org

Change-Id: I480f3814283d5a4d9970d388764a21811d5ed48e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 675997
Reviewed-on: https://chromium-review.googlesource.com/764513
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#515658}
[modify] https://crrev.com/beec1c5a10abc829eb9719bc8fb1f1bfc4c4a90f/BUILD.gn
[modify] https://crrev.com/beec1c5a10abc829eb9719bc8fb1f1bfc4c4a90f/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/beec1c5a10abc829eb9719bc8fb1f1bfc4c4a90f/tools/perf/core/perf_data_generator.py

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/e3bfefb410652d30658c112b862175d22ca75672

commit e3bfefb410652d30658c112b862175d22ca75672
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Nov 10 22:08:52 2017

Align float access in InterleavedAttributeData perf test

Used to crash on arm because of unaligned float access in positionColorData

BUG=chromium:675997

Change-Id: Iadc705986700248ce3cff9bb33fcd72c94ad1c59
Reviewed-on: https://chromium-review.googlesource.com/764688
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/e3bfefb410652d30658c112b862175d22ca75672/src/tests/perf_tests/InterleavedAttributeData.cpp

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda02d65700f82aa30b5343f300cba07d96b2bca

commit eda02d65700f82aa30b5343f300cba07d96b2bca
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Sat Nov 11 01:35:04 2017

Roll src/third_party/angle/ 38d92b59c..e3bfefb41 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/38d92b59c4b7..e3bfefb41065

$ git log 38d92b59c..e3bfefb41 --date=short --no-merges --format='%ad %ae %s'
2017-11-10 ynovikov Align float access in InterleavedAttributeData perf test
2017-11-09 jmadill Vulkan: Implement Buffer updates.

Created with:
  roll-dep src/third_party/angle
BUG=675997


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ied4a28e58bf1761735e0d5504882b2bf8c84ccc6
Reviewed-on: https://chromium-review.googlesource.com/764576
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515782}
[modify] https://crrev.com/eda02d65700f82aa30b5343f300cba07d96b2bca/DEPS

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a6e635083f3a42166078ea53d611332d9b693cd

commit 8a6e635083f3a42166078ea53d611332d9b693cd
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Sat Nov 11 02:00:40 2017

Reland "Run angle_perftests on Nexus 5X Perf bot"

This is a reland of 46aa3c2546addfe0ff5dcb663b97ccef345404ec
Crashing test was fixed by
https://chromium-review.googlesource.com/764688

Original change's description:
> Run angle_perftests on Nexus 5X Perf bot
>
> Also build angle_perftests on Android builders
>
> BUG=675997
> TBR=eyaich@chromium.org,dpranke@chromium.org
>
> Change-Id: I9e73e19599e3cc435f02960839f2e780402d0188
> Reviewed-on: https://chromium-review.googlesource.com/752582
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515462}

TBR=eyaich@chromium.org,dpranke@chromium.org

Bug: 675997
Change-Id: I3f9617df32186d1a80937e3f6598af75a54e851b
Reviewed-on: https://chromium-review.googlesource.com/764747
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515791}
[modify] https://crrev.com/8a6e635083f3a42166078ea53d611332d9b693cd/BUILD.gn
[modify] https://crrev.com/8a6e635083f3a42166078ea53d611332d9b693cd/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/8a6e635083f3a42166078ea53d611332d9b693cd/tools/perf/core/perf_data_generator.py

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/34922a64225ba62eaed82880538cde514a6fd61c

commit 34922a64225ba62eaed82880538cde514a6fd61c
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Sun Nov 12 20:29:40 2017

Roll skia/third_party/externals/angle2/ 3a9090fa0..703671e9f (9 commits)

https://chromium.googlesource.com/angle/angle.git/+log/3a9090fa0bfd..703671e9fddc

$ git log 3a9090fa0..703671e9f --date=short --no-merges --format='%ad %ae %s'
2017-11-08 oetuaho Unify extension behavior checks
2017-11-10 oetuaho Add flag for turning off initializing variables with loops
2017-11-07 jgilbert Remove formatType arg from computeCompressedImageSize.
2017-11-10 jmadill Optimize ShaderVariable::isBuiltIn.
2017-11-10 thomasanderson Add missing include to stddef.h on arm
2017-10-17 cwallez Use a packed enum for buffer targets.
2017-11-10 ynovikov Align float access in InterleavedAttributeData perf test
2017-11-09 jmadill Vulkan: Implement Buffer updates.
2017-09-13 yizhou.jiang Workaround Intel driver bug on D3D when renderering with no render target

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 735497 ,675997


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=brianosman@google.com

Change-Id: I3f1f4562db5d03660ab5cc7633689479f367307b
Reviewed-on: https://skia-review.googlesource.com/70482
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/34922a64225ba62eaed82880538cde514a6fd61c/DEPS

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a59fbd5d1ec44f6f814647f3a923269edbac6b

commit e8a59fbd5d1ec44f6f814647f3a923269edbac6b
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Sun Nov 12 22:08:30 2017

Roll src/third_party/skia/ 24e4cc708..34922a642 (2 commits)

https://skia.googlesource.com/skia.git/+log/24e4cc7087bc..34922a64225b

$ git log 24e4cc708..34922a642 --date=short --no-merges --format='%ad %ae %s'
2017-11-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 3a9090fa0..703671e9f (9 commits)
2017-11-12 brianosman Suppress warning 4577 (noexcept used with no exception handling mechanism specified)

Created with:
  roll-dep src/third_party/skia
BUG= 735497 ,675997


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I99d4906375ff3250578415f75c6a3e12ee871eb7
Reviewed-on: https://chromium-review.googlesource.com/765568
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515871}
[modify] https://crrev.com/e8a59fbd5d1ec44f6f814647f3a923269edbac6b/DEPS

Project Member

Comment 30 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcb8cd5328c38bc355e5a1097278b26cfd59fa65

commit dcb8cd5328c38bc355e5a1097278b26cfd59fa65
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Mar 23 23:08:49 2018

Run angle_perftests on all Android GPU.FYI bots

TBR=kbr@chromium.org
BUG=675997

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I688e9e0987a3359c904f3be9ff1cd4f26efc4d1d
Reviewed-on: https://chromium-review.googlesource.com/978627
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545613}
[modify] https://crrev.com/dcb8cd5328c38bc355e5a1097278b26cfd59fa65/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/dcb8cd5328c38bc355e5a1097278b26cfd59fa65/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 31 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc9d72c2c6d103d11fd9a408a119c9b5c2cad9a

commit 3bc9d72c2c6d103d11fd9a408a119c9b5c2cad9a
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Mar 28 20:35:25 2018

Run angle_perftests on more Android Perf bots

Used to run only on Nexus 5X, now run on all, except Nexus 6,
which is known to have driver issues causing test to crash.

BUG=675997

Change-Id: I1295b2dd8f113eee02d8fd695bf58c909549c1c5
Reviewed-on: https://chromium-review.googlesource.com/982972
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546585}
[modify] https://crrev.com/3bc9d72c2c6d103d11fd9a408a119c9b5c2cad9a/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/3bc9d72c2c6d103d11fd9a408a119c9b5c2cad9a/tools/perf/core/perf_data_generator.py

Project Member

Comment 32 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74bb05aef82d3e6eec8988d23cde6217bbcdd0b6

commit 74bb05aef82d3e6eec8988d23cde6217bbcdd0b6
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Mar 29 18:46:30 2018

Don't run angle_perftests on Android One

Crashes and log is not enough to understand the reason.

TBR=eyaich@chromium.org
BUG=675997

Change-Id: Ic822afad64fcba13303d56ae2f6a149bda3d69ec
Reviewed-on: https://chromium-review.googlesource.com/986645
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546890}
[modify] https://crrev.com/74bb05aef82d3e6eec8988d23cde6217bbcdd0b6/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/74bb05aef82d3e6eec8988d23cde6217bbcdd0b6/tools/perf/core/perf_data_generator.py

Blockedon: 920325
Project Member

Comment 34 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce4c3b883a3d5c172aba463adc2d406797228df5

commit ce4c3b883a3d5c172aba463adc2d406797228df5
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Jan 10 23:26:26 2019

Add angle_perftests to Windows 10 perf bot.

This will allow gathering results on this configuration.
The tests are already running on the ANGLE and Chrome
Intel bots to ensure they don't break.

Bug: 675997
Change-Id: If5cdde344014f60ef0bdc91f3b3a888af609530d
Reviewed-on: https://chromium-review.googlesource.com/c/1403678
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621799}
[modify] https://crrev.com/ce4c3b883a3d5c172aba463adc2d406797228df5/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/ce4c3b883a3d5c172aba463adc2d406797228df5/tools/perf/core/perf_data_generator.py

Blockedon: 922443
Blockedon: 922444

Comment 37 by jmad...@chromium.org, Today (9 hours ago)

Blockedon: 924618

Sign in to add a comment