New issue
Advanced search Search tips

Issue 675987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert Analyser Audit tests to testharness

Project Member Reported by rtoy@chromium.org, Dec 20 2016

Issue description

Convert the Analyser tests that use Audit to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdbfd895a9da23367f3d34465b78047cdc1de4e3

commit bdbfd895a9da23367f3d34465b78047cdc1de4e3
Author: rtoy <rtoy@chromium.org>
Date: Wed Dec 21 18:45:46 2016

Convert Analyser tests to use testharness

The follow bash script converted the tests using Audit to use
testharness instead of js-test:

for f in `grep -l Audit *.html`
do
  # Replace js-test.js with testharness.js and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove functions that don't exist anymore.
  sed -i '/^[ 	]*\(description(".*")\|finishJSTest()\);[ 	]*/d' $f
done

However, a few files needed manual adjustment because they used
testPassed()/testFailed(), which no longer exists.  These were either
removed or replaced by Should().summarize().

The expected results files were manually removed.

BUG= 675987 
TEST=Analyser/* passes

Review-Url: https://codereview.chromium.org/2595633002
Cr-Commit-Position: refs/heads/master@{#440166}

[delete] https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data-expected.txt
[modify] https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data.html
[delete] https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix-expected.txt
[modify] https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html
[delete] https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-float-data-expected.txt
[modify] https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-float-data.html
[delete] https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-expected.txt
[delete] https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-smoothing-expected.txt
[modify] https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html
[modify] https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html
[delete] https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt
[modify] https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html
[delete] https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-zero-expected.txt
[modify] https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-zero.html

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b84b6780b2a125d782037945ffcb37f481cf4587

commit b84b6780b2a125d782037945ffcb37f481cf4587
Author: rtoy <rtoy@chromium.org>
Date: Thu Dec 22 21:31:48 2016

Convert to use testharness.js

Also converted to use the new Audit. Only the bare minimum changes
were made.

BUG= 675987 
TEST=automatic-pull-node.html

Review-Url: https://codereview.chromium.org/2591923002
Cr-Commit-Position: refs/heads/master@{#440510}

[delete] https://crrev.com/f24759eb82410ae9383cc527bb6aecb7f72d2747/third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node-expected.txt
[modify] https://crrev.com/b84b6780b2a125d782037945ffcb37f481cf4587/third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faa3e9c3de15cf738fac0bc21406f2af3cc424c7

commit faa3e9c3de15cf738fac0bc21406f2af3cc424c7
Author: rtoy <rtoy@chromium.org>
Date: Tue Jan 03 21:18:29 2017

Convert realtimeanalyser-fft-scaling to testharness

Test converted to use testharness and new Audit.  By doing this, we
also remove the flakiness caused by oncomplete handler finishing at
different times.

The expected result file is also removed.

BUG= 675987 ,  676708 
TEST=realtimeanalyser-fft-scaling.html

Review-Url: https://codereview.chromium.org/2596983004
Cr-Commit-Position: refs/heads/master@{#441209}

[delete] https://crrev.com/c0304f6696623d76672a4c8fbefa16378c3137b8/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling-expected.txt
[modify] https://crrev.com/faa3e9c3de15cf738fac0bc21406f2af3cc424c7/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ccc5796ad0f110d4638570b0bead2f197200ee3

commit 1ccc5796ad0f110d4638570b0bead2f197200ee3
Author: rtoy <rtoy@chromium.org>
Date: Wed Jan 04 20:07:10 2017

Convert realtimeanalyser-fft-sizing tst to testharness

Test converted to use testharness and new Audit.

The expected result file is also removed.

BUG= 675987 
TEST=realtimeanalyser-fft-sizing.html

Review-Url: https://codereview.chromium.org/2603483002
Cr-Commit-Position: refs/heads/master@{#441442}

[delete] https://crrev.com/ba7b9d74bdd0fa555c7997c459ddd0d6c05cc78a/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing-expected.txt
[modify] https://crrev.com/1ccc5796ad0f110d4638570b0bead2f197200ee3/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing.html

Comment 6 by rtoy@chromium.org, Jan 5 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
All tests in Analyser have been converted to testharness now.

Sign in to add a comment