New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675979 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 701863



Sign in to add a comment

InputEvent: Remove unused |inputType()| from |UndoStep| and |EditCommandComposition|

Project Member Reported by chongz@chromium.org, Dec 20 2016

Issue description

Previously |inputType()| was added to |UndoStep| and |EditCommandComposition| to memorize the original input type of the command.

However we don't need them anymore since the new spec only requires undo/redo to fire |InputEvent| with type "historyUndo" and "historyRedo".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dfe5606ddaba817853aeff212b43c67be91696f

commit 1dfe5606ddaba817853aeff212b43c67be91696f
Author: chongz <chongz@chromium.org>
Date: Wed Dec 21 20:04:45 2016

[InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition|

|inputType()| was added before but never used, please see bug for more
info.

This CL doesn't have any behavior change.

BUG=675979

Review-Url: https://codereview.chromium.org/2590283002
Cr-Commit-Position: refs/heads/master@{#440193}

[modify] https://crrev.com/1dfe5606ddaba817853aeff212b43c67be91696f/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/1dfe5606ddaba817853aeff212b43c67be91696f/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
[modify] https://crrev.com/1dfe5606ddaba817853aeff212b43c67be91696f/third_party/WebKit/Source/core/editing/commands/UndoStep.h

Comment 2 by chongz@chromium.org, Dec 21 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d814290cfc839f8e7d02b632e33026c8878a1b3d

commit d814290cfc839f8e7d02b632e33026c8878a1b3d
Author: chongz <chongz@chromium.org>
Date: Fri Jan 13 18:27:58 2017

Revert of [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition| (patchset #1 id:1 of https://codereview.chromium.org/2590283002/ )

Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.

TBR=yosin@chromium.org

Original issue's description:
> [InputEvent] Remove unused |inputType()| from |UndoStep| and |EditCommandComposition|
>
> |inputType()| was added before but never used, please see bug for more
> info.
>
> This CL doesn't have any behavior change.
>
> BUG=675979
>
> Committed: https://crrev.com/1dfe5606ddaba817853aeff212b43c67be91696f
> Cr-Commit-Position: refs/heads/master@{#440193}

TBR=tkent@chromium.org,xiaochengh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=675979

Review-Url: https://codereview.chromium.org/2637443002
Cr-Commit-Position: refs/heads/master@{#443618}

[modify] https://crrev.com/d814290cfc839f8e7d02b632e33026c8878a1b3d/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/d814290cfc839f8e7d02b632e33026c8878a1b3d/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
[modify] https://crrev.com/d814290cfc839f8e7d02b632e33026c8878a1b3d/third_party/WebKit/Source/core/editing/commands/UndoStep.h

Comment 4 by chongz@chromium.org, Jan 13 2017

Status: Assigned (was: Fixed)
Re-open as we want to start over according to https://codereview.chromium.org/2627103003/#msg12.

Comment 5 by chongz@chromium.org, Mar 15 2017

Blocking: 701863

Comment 6 by chongz@chromium.org, Mar 15 2017

Blocking: -585875

Comment 7 by chongz@chromium.org, Jan 11 2018

Cc: chongz@chromium.org yosin@chromium.org xiaoche...@chromium.org
Components: Blink>Editing
Owner: ----
Status: Available (was: Assigned)
Un-assigning myself as I no longer work on InputEvent.
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment