New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675975 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Refactor the focused node tracking code from RenderViewHost into WebContents

Project Member Reported by ekaramad@chromium.org, Dec 20 2016

Issue description

The main logic is implemented in WebContentsImpl. We should move the methods from public API to WebContents. This will also obviate the need for the corresponding helper methods in RenderViewHostDelegate.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1f939d7ba5a1c17f045d6b622909902743454c

commit 5c1f939d7ba5a1c17f045d6b622909902743454c
Author: ekaramad <ekaramad@chromium.org>
Date: Wed Jan 25 02:05:23 2017

[refactor] - Move IsFocusedElementEditable() and ClearFocusedElement() from RenderViewHost to WebContents.

The implementation logic for both of the methods is inside WebContentsImpl.
It only makes sense to remove the methods to WebContents and also get rid
of the helper methods in RenderViewHostDelegate.

BUG= 675975 

Review-Url: https://codereview.chromium.org/2641403002
Cr-Commit-Position: refs/heads/master@{#445910}

[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/chrome/browser/ui/views/find_bar_host.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/browser/renderer_host/render_view_host_browsertest.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/browser/renderer_host/render_view_host_delegate.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/browser/renderer_host/render_view_host_delegate.h
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/public/browser/render_view_host.h
[modify] https://crrev.com/5c1f939d7ba5a1c17f045d6b622909902743454c/content/public/browser/web_contents.h

Description: Show this description
Status: Fixed (was: Assigned)
Modified the description to only include refactoring RVH code. The WebContentsObserver suggestion needs major work in ChromeOS AccessibilityManager classes and does not fit in the scope of this refactoring. Also marking the bug as fixed following comment #1.

Sign in to add a comment