New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675963 link

Starred by 1 user
Status: Fixed
Owner:
█ zqzh...@chromium.org
Android MediaRouter only (left Chro...
Closed: Jan 2017
Cc:
fbeaufort@chromium.org
█ avayvod@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Implement MediaSession.setActionHandler()

Project Member Reported by zqzh...@chromium.org, Dec 20 2016 
As the spec is going to change from event listeners to MediaSession.setActionHandler(), we need to update the implementation
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3194c19094e8d713487876ebfd15821752a31739

commit 3194c19094e8d713487876ebfd15821752a31739
Author: zqzhang <zqzhang@chromium.org>
Date: Fri Jan 06 01:25:17 2017

[Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions

As the MediaSession spec changed from using event-listener-based
to callback-based fashion for media controls, we need to keep the
implementation up to date.

Spec PR:
https://github.com/WICG/mediasession/pull/159

BUG= 675963 

Review-Url: https://codereview.chromium.org/2589893002
Cr-Commit-Position: refs/heads/master@{#441787}

[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[add] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/media/mediasession/mediasession-setactionhandler.html
[add] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-action-reaches-client.html
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/bindings/modules/v8/custom/V8MediaSessionCustom.cpp
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/bindings/modules/v8/custom/custom.gni
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/core/events/EventTypeNames.in
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/modules/EventTargetModulesFactory.in
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/modules/mediasession/MediaSession.h
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/modules/mediasession/MediaSession.idl
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.cpp
[modify] https://crrev.com/3194c19094e8d713487876ebfd15821752a31739/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h

Comment 2 by zqzh...@chromium.org, Jan 6 2017

Cc: fbeaufort@chromium.org
Status: Fixed (was: Started)
\o/
►

Sign in to add a comment