ClickBasedCategoryRanker::ClearHistory must preserve remote categories |
||||
Issue descriptionCurrently ClearHistory removes all remote categories, however, it should bring their counts to 0 and move them to the end instead. Removing may not work, since it is not a provider's responsiblity to reregister categories on history removal.
,
Dec 22 2016
Oooops ... this is specifically about ClickBasedCategoryRanker::ClearHistory. Back to Vitalii :-)
,
Dec 29 2016
,
Dec 30 2016
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6343b2cefff8bce62994da5fc6b6156c7d6409a6 commit 6343b2cefff8bce62994da5fc6b6156c7d6409a6 Author: vitaliii <vitaliii@chromium.org> Date: Wed Jan 04 07:57:11 2017 [NTP::SectionOrder] Preserve added categories on ClearHistory. Before this CL all categories, which were added using AppendCategoryIfNecessary, were removed on ClearHistory. Since it is not required to reregister them, there were simply not shown at all. After this CL they are preserved (sorted by id). BUG= 675953 Review-Url: https://codereview.chromium.org/2605353004 Cr-Commit-Position: refs/heads/master@{#441336} [modify] https://crrev.com/6343b2cefff8bce62994da5fc6b6156c7d6409a6/components/ntp_snippets/category_rankers/click_based_category_ranker.cc [modify] https://crrev.com/6343b2cefff8bce62994da5fc6b6156c7d6409a6/components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc [modify] https://crrev.com/6343b2cefff8bce62994da5fc6b6156c7d6409a6/components/ntp_snippets/content_suggestions_service.cc
,
Jan 4 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by fi...@chromium.org
, Dec 22 2016Owner: tschumann@chromium.org