New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675946 link

Starred by 1 user
Status: Fixed
Owner:
vitaliii@chromium.org
Closed: Jan 2017
Cc:
ntp-dev+bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 646841



Sign in to add a comment

Make a flag to choose category ranker.

Project Member Reported by vitaliii@chromium.org, Dec 20 2016 
Currently there is no way to change category ranker except changing the code. Instead we need to provide a flag, so that we can control it from Finch and test it without enabling by default.

Comment 1 by vitaliii@chromium.org, Dec 20 2016

Labels: zine-16-12-19
Status: Started (was: Assigned)
CL https://codereview.chromium.org/2590133003

Comment 2 by vitaliii@chromium.org, Dec 23 2016 

Previous CL was based on MULTI_VALUE_TYPE.
Instead we decided to use FEATURE_WITH_VARIATIONS_VALUE_TYPE.
The new CL is https://codereview.chromium.org/2595883002/.

Comment 3 by vitaliii@chromium.org, Jan 2 2017

Labels: zine-17-01-02
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a64fb41f45ac025608887c192ecdddf1be477846

commit a64fb41f45ac025608887c192ecdddf1be477846
Author: vitaliii <vitaliii@chromium.org>
Date: Wed Jan 04 07:40:29 2017

[NTP::SectionOrder] Add a flag to choose category ranker.

This CL adds a flag to choose a category ranker.
The default is ConstantCategoryRanker.

I had to add FEATURE_WITH_VARIATIONS_VALUE_TYPE (but not
MULTI_VALUE_TYPE), because the latter presumably cannot be controled via
variations service.

BUG= 675946 

Review-Url: https://codereview.chromium.org/2595883002
Cr-Commit-Position: refs/heads/master@{#441332}

[modify] https://crrev.com/a64fb41f45ac025608887c192ecdddf1be477846/chrome/app/generated_resources.grd
[modify] https://crrev.com/a64fb41f45ac025608887c192ecdddf1be477846/chrome/browser/about_flags.cc
[modify] https://crrev.com/a64fb41f45ac025608887c192ecdddf1be477846/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/a64fb41f45ac025608887c192ecdddf1be477846/components/ntp_snippets/features.cc
[modify] https://crrev.com/a64fb41f45ac025608887c192ecdddf1be477846/components/ntp_snippets/features.h
[modify] https://crrev.com/a64fb41f45ac025608887c192ecdddf1be477846/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
[modify] https://crrev.com/a64fb41f45ac025608887c192ecdddf1be477846/tools/metrics/histograms/histograms.xml

Comment 5 by vitaliii@chromium.org, Jan 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment