New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675905 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Not possible to disable or blacklist WebGL2 with --in-process-gpu

Reported by rog...@opera.com, Dec 20 2016

Issue description

Chrome Version: 57.0.2957.0
OS: Linux (locally built content_shell)

What steps will reproduce the problem?
(1) ./content_shell --no-sandbox --in-process-gpu --disable-es3-apis http://webglreport.com/?v=2

What is the expected result?
WebGL2 should be unsupported.

What happens instead?
WebGL2 is supported.

Please use labels and text to provide additional information.
Loading chrome:gpu lists WebGL2 as "Disabled" but it is still possible to use WebGL2.
Removing --in-process-gpu makes --disable-es3-apis work as expected.

I also tried blacklisting WebGL2, but that also has no effect with --in-process-gpu.

I did some digging and found that ES3 APIs are disabled by setting the GpuPreferences::enable_es3_apis to false. This is handled in GpuDataManagerImplPrivate::AppendGpuCommandLine(...) but that function is called without a gpu_preferences parameter in the case of --in-process-gpu which leaves the pref in its default state, which is to enable es3 apis.

I did not find a obvious fix for this, GetGpuPreferencesFromCommandLine() seems like a good choice but it does not have access to the feature blacklist status afaict. 
 

Comment 1 by zmo@chromium.org, Dec 20 2016

Status: WontFix (was: Untriaged)
Sorry but I don't think we should spend time doing some non-trivia refactoring to make an unsupported path work.

If you have a simple CL (no majoring rewiring of how things work), I am more than happy to review it.

Comment 2 by rog...@opera.com, Dec 21 2016

Fair point, and kind of expected, I thought it deserved a bug at least.

But I wonder if this won't also affect WebView? The issue is also reproducible using --single-process which I believe is used in that setup. If that is the case the current WebGL2 blacklist entry for Android won't have an effect.

Comment 3 by zmo@chromium.org, Dec 21 2016

Cc: -zmo@chromium.org kbr@chromium.org kainino@chromium.org
Labels: -Pri-3 Pri-2
Owner: zmo@chromium.org
Status: Assigned (was: WontFix)
Ah, then we do need to fix this.

Sign in to add a comment