New issue
Advanced search Search tips

Issue 675879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 675877



Sign in to add a comment

Clean up use_chromium_style_naming option from Blink GC plugin

Project Member Reported by dcheng@chromium.org, Dec 20 2016

Issue description

Once the Blink rename is done, we can remove the duplicated tests and the plugin option.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae0304082bf05eeb62bd74b4ba9141f26cf1accb

commit ae0304082bf05eeb62bd74b4ba9141f26cf1accb
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Apr 12 00:14:38 2017

blink_gc_plugin: Remove handling for legacy-style naming.

The plugin option is left as a stub for now, to avoid the build from
failing. It will be removed once the gn files no longer need to pass
this argument.

Bug:  675879 
Change-Id: Ib6c5da4e1d07d054704354367d12f8e34a50d41f
Reviewed-on: https://chromium-review.googlesource.com/474061
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463852}
[modify] https://crrev.com/ae0304082bf05eeb62bd74b4ba9141f26cf1accb/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
[modify] https://crrev.com/ae0304082bf05eeb62bd74b4ba9141f26cf1accb/tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp
[modify] https://crrev.com/ae0304082bf05eeb62bd74b4ba9141f26cf1accb/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h
[modify] https://crrev.com/ae0304082bf05eeb62bd74b4ba9141f26cf1accb/tools/clang/blink_gc_plugin/CMakeLists.txt
[modify] https://crrev.com/ae0304082bf05eeb62bd74b4ba9141f26cf1accb/tools/clang/blink_gc_plugin/Config.cpp
[modify] https://crrev.com/ae0304082bf05eeb62bd74b4ba9141f26cf1accb/tools/clang/blink_gc_plugin/Config.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/.gitignore
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/base_class_must_define_virtual_trace.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/base_class_must_define_virtual_trace.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/base_class_must_define_virtual_trace.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/base_requires_tracing.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/base_requires_tracing.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/base_requires_tracing.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_does_not_require_finalization.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_does_not_require_finalization.flags
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_does_not_require_finalization.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_does_not_require_finalization.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_multiple_trace_bases.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_multiple_trace_bases.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_multiple_trace_bases.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_overrides_new.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_overrides_new.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_overrides_new.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_base.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_base.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_base.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_field.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_field.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_field.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_mixin.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_mixin.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_finalization_mixin.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_trace_method.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_trace_method.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_trace_method.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_trace_method_tmpl.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_trace_method_tmpl.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/class_requires_trace_method_tmpl.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/crash_on_invalid.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/crash_on_invalid.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/crash_on_invalid.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_ptrs.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_ptrs.flags
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_ptrs.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_ptrs.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_sub.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_sub.flags
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_sub.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_sub.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super.flags
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super_neg.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super_neg.flags
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super_neg.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/cycle_super_neg.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/delayed_parsing.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/delayed_parsing.flags
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/delayed_parsing.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_access_finalized_field.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_eagerly_finalized.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_eagerly_finalized.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_eagerly_finalized.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_in_nonfinalized_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_in_nonfinalized_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/destructor_in_nonfinalized_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/fields_illegal_tracing.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/fields_illegal_tracing.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/fields_illegal_tracing.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/fields_require_tracing.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/fields_require_tracing.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/fields_require_tracing.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/finalize_after_dispatch.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/finalize_after_dispatch.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/finalize_after_dispatch.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/garbage_collected_mixin.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/garbage_collected_mixin.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/garbage_collected_mixin.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/heap/stubs.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ignore_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ignore_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ignore_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ignore_fields.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ignore_fields.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ignore_fields.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/inner_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/inner_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/inner_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/left_most_gc_base.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/left_most_gc_base.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/left_most_gc_base.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/member_in_offheap_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/member_in_offheap_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/member_in_offheap_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/non_virtual_trace.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/non_virtual_trace.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/non_virtual_trace.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/own_ptr_to_gc_managed_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/own_ptr_to_gc_managed_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/own_ptr_to_gc_managed_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/part_object_to_gc_derived_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/part_object_to_gc_derived_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/part_object_to_gc_derived_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/persistent_field_in_gc_managed_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/persistent_field_in_gc_managed_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/persistent_field_in_gc_managed_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/persistent_no_trace.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/persistent_no_trace.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/persistent_no_trace.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/polymorphic_class_with_non_virtual_trace.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/polymorphic_class_with_non_virtual_trace.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/polymorphic_class_with_non_virtual_trace.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/pure_virtual_trace.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/pure_virtual_trace.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/pure_virtual_trace.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/raw_ptr_to_gc_managed_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/raw_ptr_to_gc_managed_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/raw_ptr_to_gc_managed_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/raw_ptr_to_gc_managed_class_error.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/raw_ptr_to_gc_managed_class_error.flags
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/raw_ptr_to_gc_managed_class_error.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/raw_ptr_to_gc_managed_class_error.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ref_ptr_to_gc_managed_class.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ref_ptr_to_gc_managed_class.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/ref_ptr_to_gc_managed_class.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/register_weak_members_template.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/templated_class_with_local_class_requires_trace.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/templated_class_with_local_class_requires_trace.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/templated_class_with_local_class_requires_trace.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/test.py
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_after_dispatch_impl_error.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_collections.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_collections.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_collections.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_if_needed.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_if_needed.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_if_needed.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_templated_super.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_templated_super.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/trace_templated_super.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_dependent_scope.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.h
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_derived_from_templated_base.txt
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.cpp
[delete] https://crrev.com/f1a29ebf18d1e876df019c862c9e4f6719aff64f/tools/clang/blink_gc_plugin/tests/legacy_naming/traceimpl_error.h
[delete
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/066ba1478d4ca2a3818be9d7b58056424e296910

commit 066ba1478d4ca2a3818be9d7b58056424e296910
Author: Daniel Cheng <dcheng@chromium.org>
Date: Wed Sep 20 06:00:28 2017

Don't pass use-chromium-style-naming to the BlinkGCPlugin.

This flag is a no-op now.

TBR=tkent@chromium.org

Bug:  675879 
Change-Id: Ia540cbd4483b2f12ac5e33d41feb10c812c1c04a
Reviewed-on: https://chromium-review.googlesource.com/673966
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503065}
[modify] https://crrev.com/066ba1478d4ca2a3818be9d7b58056424e296910/third_party/WebKit/Source/BUILD.gn

Comment 3 by dcheng@chromium.org, Sep 20 2017

Status: Fixed (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/674283/ was the final bit for this (unfortunately I copy and pasted the wrong bug number...)

Sign in to add a comment