Tracking bug for issues we should clean up after the Blink rename.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b0611279ba80484dfe17163519cabbd5939c935 commit 9b0611279ba80484dfe17163519cabbd5939c935 Author: thakis <thakis@chromium.org> Date: Mon Apr 10 15:54:51 2017 Fix names of local constants after blink rename. The blink rename script renamed some constant const kFoos to k_foos. Undo that again manually. No intended behavior change. BUG= 578344 ,675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2812643002 Cr-Commit-Position: refs/heads/master@{#463281} [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/css/parser/CSSParserFastPathsTest.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/editing/EditingCommandTest.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/editing/EditorTest.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/editing/commands/SmartReplaceICU.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/frame/DOMTimerTest.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/html/HTMLTextAreaElementTest.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/platform/WebVectorTest.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/web/tests/KeyboardTest.cpp [modify] https://crrev.com/9b0611279ba80484dfe17163519cabbd5939c935/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a385fea357701f615577d64473706d36db87127 commit 4a385fea357701f615577d64473706d36db87127 Author: kouhei <kouhei@chromium.org> Date: Tue Apr 11 09:28:40 2017 ur_ls -> urls in platform/weborigin BUG=675877 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2809123002 Cr-Commit-Position: refs/heads/master@{#463588} [modify] https://crrev.com/4a385fea357701f615577d64473706d36db87127/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp [modify] https://crrev.com/4a385fea357701f615577d64473706d36db87127/third_party/WebKit/Source/platform/weborigin/SecurityPolicyTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14cd5f73bdedb05dd26b40028402ae195727061d commit 14cd5f73bdedb05dd26b40028402ae195727061d Author: kouhei <kouhei@chromium.org> Date: Tue Apr 11 11:47:30 2017 ur_ls -> urls in platform/loader/fetch BUG=675877 Review-Url: https://codereview.chromium.org/2809113002 Cr-Commit-Position: refs/heads/master@{#463598} [modify] https://crrev.com/14cd5f73bdedb05dd26b40028402ae195727061d/third_party/WebKit/Source/platform/loader/fetch/MemoryCache.cpp [modify] https://crrev.com/14cd5f73bdedb05dd26b40028402ae195727061d/third_party/WebKit/Source/platform/loader/fetch/MemoryCache.h [modify] https://crrev.com/14cd5f73bdedb05dd26b40028402ae195727061d/third_party/WebKit/Source/platform/loader/fetch/ResourceTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e commit 4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e Author: kouhei <kouhei@chromium.org> Date: Tue Apr 11 11:49:01 2017 ur_ls -> urls in ResourceFetcher Blink Reformat miss? fix BUG=675877 Review-Url: https://codereview.chromium.org/2809103002 Cr-Commit-Position: refs/heads/master@{#463599} [modify] https://crrev.com/4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [modify] https://crrev.com/4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6bb4131843342dbfede940f89a918cc29a399f9 commit e6bb4131843342dbfede940f89a918cc29a399f9 Author: thakis <thakis@chromium.org> Date: Tue Apr 11 19:09:38 2017 Fix g_k_* symbols after blink rename. These were mosty renamed because these weren't actually const in most cases, so also make all these constants actually constant in addition to renaming them. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2809983002 Cr-Commit-Position: refs/heads/master@{#463712} [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/core/html/HTMLIFrameElementSandbox.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/modules/mediasource/SourceBufferTrackBaseSupplement.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp [modify] https://crrev.com/e6bb4131843342dbfede940f89a918cc29a399f9/third_party/WebKit/Source/platform/wtf/text/StringViewTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42dcba91524903cd72eac79865d7fd0b3d23bee6 commit 42dcba91524903cd72eac79865d7fd0b3d23bee6 Author: lukasza <lukasza@chromium.org> Date: Tue Apr 11 21:57:54 2017 Blink Rename follow-up: BRs --big-rename--> _b_rs --this-fix--> _brs. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2809213003 Cr-Commit-Position: refs/heads/master@{#463790} [modify] https://crrev.com/42dcba91524903cd72eac79865d7fd0b3d23bee6/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/42dcba91524903cd72eac79865d7fd0b3d23bee6/third_party/WebKit/Source/core/dom/Node.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/957973a1cdbd77c68547ca32ebd993b882c356be commit 957973a1cdbd77c68547ca32ebd993b882c356be Author: lukasza <lukasza@chromium.org> Date: Wed Apr 12 01:01:09 2017 Blink Rename follow-up: XHRs --big-rename--> _xh_rs --this-fix--> _xhrs. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2808093005 Cr-Commit-Position: refs/heads/master@{#463866} [modify] https://crrev.com/957973a1cdbd77c68547ca32ebd993b882c356be/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/957973a1cdbd77c68547ca32ebd993b882c356be/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h [modify] https://crrev.com/957973a1cdbd77c68547ca32ebd993b882c356be/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88f78352fa3d325662153e2a1e50f46cccce1303 commit 88f78352fa3d325662153e2a1e50f46cccce1303 Author: lukasza <lukasza@chromium.org> Date: Thu Apr 13 02:31:35 2017 Blink Rename follow-up: URLs --big-rename--> _ur_ls --this-fix--> _urls. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2810073002 Cr-Commit-Position: refs/heads/master@{#464252} [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.h [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.h [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/frame/FrameSerializer.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/frame/FrameSerializer.h [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/html/PublicURLManager.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp [modify] https://crrev.com/88f78352fa3d325662153e2a1e50f46cccce1303/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db535bebe4f4bc466d1c3fb74787532ade01fa71 commit db535bebe4f4bc466d1c3fb74787532ade01fa71 Author: lukasza <lukasza@chromium.org> Date: Thu Apr 13 06:21:38 2017 Blink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb). The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2817503002 Cr-Commit-Position: refs/heads/master@{#464318} [modify] https://crrev.com/db535bebe4f4bc466d1c3fb74787532ade01fa71/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/db535bebe4f4bc466d1c3fb74787532ade01fa71/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf158122b56fbd907a875438a4e2c40193be6f07 commit cf158122b56fbd907a875438a4e2c40193be6f07 Author: lukasza <lukasza@chromium.org> Date: Thu Apr 13 08:39:27 2017 Blink Rename follow-up: S3TCsRGB should become _s3tc_srgb (not _s3t_cs_rgb). The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2814853002 Cr-Commit-Position: refs/heads/master@{#464341} [modify] https://crrev.com/cf158122b56fbd907a875438a4e2c40193be6f07/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp [modify] https://crrev.com/cf158122b56fbd907a875438a4e2c40193be6f07/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.h [modify] https://crrev.com/cf158122b56fbd907a875438a4e2c40193be6f07/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp [modify] https://crrev.com/cf158122b56fbd907a875438a4e2c40193be6f07/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b963a8aa430d5937da3f3cdc7bafcd614d36877 commit 4b963a8aa430d5937da3f3cdc7bafcd614d36877 Author: timloh <timloh@chromium.org> Date: Tue Apr 18 08:42:08 2017 Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink rename This patch updates the scripts for keeping histograms.xml up-to-date so that they work correctly after the recent Blink rename. While all the feature enums are now written as kFooMetric, we'd prefer to have them show as FooMetric in the histograms so support is added for dropping a leading 'k'. This patch also adds support for enums with super long names, such as kUncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted, which cause the enum initialization to end up on a separate line. BUG=675877 Review-Url: https://codereview.chromium.org/2825573003 Cr-Commit-Position: refs/heads/master@{#465178} [modify] https://crrev.com/4b963a8aa430d5937da3f3cdc7bafcd614d36877/third_party/WebKit/Source/core/frame/PRESUBMIT.py [modify] https://crrev.com/4b963a8aa430d5937da3f3cdc7bafcd614d36877/tools/metrics/histograms/update_histogram_enum.py [modify] https://crrev.com/4b963a8aa430d5937da3f3cdc7bafcd614d36877/tools/metrics/histograms/update_use_counter_feature_enum.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76e13266457493c2c9a3c5a3c412e4ac713fbcc1 commit 76e13266457493c2c9a3c5a3c412e4ac713fbcc1 Author: lukasza <lukasza@chromium.org> Date: Tue Apr 18 18:55:39 2017 Fix more g_k_* symbols after blink rename. Majority of g_k_* symbols were fixed by r463712 - this CL fixes 2 more cases. These were renamed because these weren't actually const in most cases, so also make all these constants actually constant in addition to renaming them. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2819293003 Cr-Commit-Position: refs/heads/master@{#465309} [modify] https://crrev.com/76e13266457493c2c9a3c5a3c412e4ac713fbcc1/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp [modify] https://crrev.com/76e13266457493c2c9a3c5a3c412e4ac713fbcc1/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f40fd439d92c1c788d54e71dae144c6dead3efe6 commit f40fd439d92c1c788d54e71dae144c6dead3efe6 Author: lukasza <lukasza@chromium.org> Date: Thu Apr 27 03:17:37 2017 Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode. The renaming tool skipped renaming |begin| and |end| methods with an assumption that they should mimic STL naming convention in all cases. This assumption is not true for PrintContext::begin and PrintContext::end methods - this CL renames them to the Chromium style (expanding their names to BeginPrintMode and EndPrintMode). BUG=675877 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2838343003 Cr-Commit-Position: refs/heads/master@{#467564} [modify] https://crrev.com/f40fd439d92c1c788d54e71dae144c6dead3efe6/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/f40fd439d92c1c788d54e71dae144c6dead3efe6/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp [modify] https://crrev.com/f40fd439d92c1c788d54e71dae144c6dead3efe6/third_party/WebKit/Source/core/page/PrintContext.cpp [modify] https://crrev.com/f40fd439d92c1c788d54e71dae144c6dead3efe6/third_party/WebKit/Source/core/page/PrintContext.h [modify] https://crrev.com/f40fd439d92c1c788d54e71dae144c6dead3efe6/third_party/WebKit/Source/core/page/PrintContextTest.cpp [modify] https://crrev.com/f40fd439d92c1c788d54e71dae144c6dead3efe6/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
There are still 64 .h/.cpp files containing m_interCaps member variables: https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit+-file:bindings/tests+file:%5C.(cpp%7Ch)$&all=1&type=cs
Some of these are strings or comments referring to variables which were renamed, others are actual variables or macro magic. Here's a spreadsheet to claim fixing things so people can do it in parallel: https://docs.google.com/spreadsheets/d/1px9A3CxS-Y2r51wsD7_yhqnH_YJTnwb5AQAkRuJAs6E/edit#gid=0
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fcc6d6a6ac58eabe2c77a804e3220318a0dc1f3 commit 1fcc6d6a6ac58eabe2c77a804e3220318a0dc1f3 Author: thakis <thakis@chromium.org> Date: Wed May 03 17:08:56 2017 blink: Remove some (non-comment, non-bindings-tests) occurences of m_instVars. See https://cs.chromium.org/search/?q=%5E%5B%5E/%5D*%5Cbm_+file:webkit&type=cs BUG=675877 Review-Url: https://codereview.chromium.org/2861743002 Cr-Commit-Position: refs/heads/master@{#469010} [modify] https://crrev.com/1fcc6d6a6ac58eabe2c77a804e3220318a0dc1f3/third_party/WebKit/LayoutTests/compositing/child-transform-layer-rounding.html [modify] https://crrev.com/1fcc6d6a6ac58eabe2c77a804e3220318a0dc1f3/third_party/WebKit/Source/bindings/core/v8/V8BindingDesign.md [modify] https://crrev.com/1fcc6d6a6ac58eabe2c77a804e3220318a0dc1f3/third_party/WebKit/Source/platform/wtf/Assertions.cpp
danakj: I don't have permissions to look at that sheet (tried both @chromium and @google)
ooops, fixed for @chromium. thanks
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dc8ae2e46895de7953b0427e40817887135270b commit 3dc8ae2e46895de7953b0427e40817887135270b Author: thakis <thakis@chromium.org> Date: Wed May 03 21:47:24 2017 Delete unused core/layout/GapRects.h BUG=675877 Review-Url: https://codereview.chromium.org/2859923002 Cr-Commit-Position: refs/heads/master@{#469142} [modify] https://crrev.com/3dc8ae2e46895de7953b0427e40817887135270b/third_party/WebKit/Source/core/layout/BUILD.gn [delete] https://crrev.com/2d3151bb4c3bf0346ceec9c4b43f895607fe8d2c/third_party/WebKit/Source/core/layout/GapRects.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5006a34633088cb6c63850b2bfd0df5ca8fb79f4 commit 5006a34633088cb6c63850b2bfd0df5ca8fb79f4 Author: thakis <thakis@chromium.org> Date: Wed May 03 22:07:17 2017 Remove unused .h files in modules/crypto. BUG=675877 Review-Url: https://codereview.chromium.org/2858053002 Cr-Commit-Position: refs/heads/master@{#469156} [delete] https://crrev.com/550f56c09c04dc7d09f958d41e832d3c94069978/third_party/WebKit/Source/modules/crypto/AesKeyAlgorithm.h [modify] https://crrev.com/5006a34633088cb6c63850b2bfd0df5ca8fb79f4/third_party/WebKit/Source/modules/crypto/BUILD.gn [delete] https://crrev.com/550f56c09c04dc7d09f958d41e832d3c94069978/third_party/WebKit/Source/modules/crypto/KeyAlgorithm.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c028bac2501124f9e9beb3f9969c9654e0398c0 commit 2c028bac2501124f9e9beb3f9969c9654e0398c0 Author: thakis <thakis@chromium.org> Date: Wed May 03 22:08:50 2017 Remove unused audio/ipp. Nothing ever defines WEBAUDIO_IPP, so this file is dead. BUG=675877 Review-Url: https://codereview.chromium.org/2857853006 Cr-Commit-Position: refs/heads/master@{#469158} [modify] https://crrev.com/2c028bac2501124f9e9beb3f9969c9654e0398c0/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/e85d0513cdbaeeff936cc30f1d73ae9887d1df43/third_party/WebKit/Source/platform/audio/ipp/FFTFrameIPP.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a06c69d34196768c6273d5ba15fa4d2711bf300 commit 3a06c69d34196768c6273d5ba15fa4d2711bf300 Author: thakis <thakis@chromium.org> Date: Wed May 03 22:20:12 2017 Remove CHECK_FAST_PATH_SLOW_PATH_EQUALITY This code hasn't been building since the blink reformat, suggesting it's unused. BUG=675877 Review-Url: https://codereview.chromium.org/2863483002 Cr-Commit-Position: refs/heads/master@{#469163} [modify] https://crrev.com/3a06c69d34196768c6273d5ba15fa4d2711bf300/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp [modify] https://crrev.com/3a06c69d34196768c6273d5ba15fa4d2711bf300/third_party/WebKit/Source/core/layout/PaintInvalidationState.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6 commit 8d0c60dcfe3e5f091be962645a7a41bc32aef0e6 Author: lukasza <lukasza@chromium.org> Date: Thu May 04 17:03:47 2017 Rename |m_scriptState| to |script_state_| in IDL bindings. This CL was generated mechanically with: $ git grep -l m_scriptState -- third_party/WebKit/Source | \ xargs -n 1 sed -i -e 's/\bm_scriptState\b/script_state_/g' No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2857853007 Cr-Commit-Position: refs/heads/master@{#469363} [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h [modify] https://crrev.com/8d0c60dcfe3e5f091be962645a7a41bc32aef0e6/third_party/WebKit/Source/platform/bindings/ScriptState.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/270315a23344b1ca5a714d1e4d1f76fbbab43538 commit 270315a23344b1ca5a714d1e4d1f76fbbab43538 Author: hiroshige <hiroshige@chromium.org> Date: Thu May 04 22:05:13 2017 Rename Resource::GetError() to FinishAsError() In Blink Renaming, Resource::error() was incorrectly renamed to GetError(). This CL re-renames it to FinishAsError(). This CL doesn't rename it to Error() because Error() looks like the getter of |Resource::error_|. BUG=675877 Review-Url: https://codereview.chromium.org/2855883004 Cr-Commit-Position: refs/heads/master@{#469487} [modify] https://crrev.com/270315a23344b1ca5a714d1e4d1f76fbbab43538/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp [modify] https://crrev.com/270315a23344b1ca5a714d1e4d1f76fbbab43538/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp [modify] https://crrev.com/270315a23344b1ca5a714d1e4d1f76fbbab43538/third_party/WebKit/Source/core/loader/resource/ImageResource.h [modify] https://crrev.com/270315a23344b1ca5a714d1e4d1f76fbbab43538/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp [modify] https://crrev.com/270315a23344b1ca5a714d1e4d1f76fbbab43538/third_party/WebKit/Source/platform/loader/fetch/Resource.h [modify] https://crrev.com/270315a23344b1ca5a714d1e4d1f76fbbab43538/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8 commit c9672e28ad57ca92994dfaa20c7b0f9991fddbd8 Author: lukasza <lukasza@chromium.org> Date: Fri May 05 00:15:00 2017 Rename |m_callback| to |callback_| in IDL bindings. This CL was generated mechanically with: $ git grep -l m_callback -- third_party/WebKit/Source | \ xargs -n 1 sed -i -e 's/\bm_callback\b/callback_/g' No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2858153004 Cr-Commit-Position: refs/heads/master@{#469538} [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp [modify] https://crrev.com/c9672e28ad57ca92994dfaa20c7b0f9991fddbd8/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96c02c8b0f96f995b15d4efe5783a2c4015999a0 commit 96c02c8b0f96f995b15d4efe5783a2c4015999a0 Author: thakis <thakis@chromium.org> Date: Mon May 08 16:44:03 2017 Fix some m_instVar instances in wtf/ cf https://docs.google.com/spreadsheets/d/1px9A3CxS-Y2r51wsD7_yhqnH_YJTnwb5AQAkRuJAs6E/edit#gid=0 Remove StringImpl's STRING_STATS feature -- it hasn't been compiling for a while. If someone wants to use it, they can revive it from revision history and make it compile then. BUG=675877 Review-Url: https://codereview.chromium.org/2856123004 Cr-Commit-Position: refs/heads/master@{#470015} [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/heap/ThreadState.cpp [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/heap/ThreadState.h [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/wtf/DynamicAnnotations.h [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/wtf/HashTable.h [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/wtf/LinkedHashSet.h [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/wtf/Vector.h [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp [modify] https://crrev.com/96c02c8b0f96f995b15d4efe5783a2c4015999a0/third_party/WebKit/Source/platform/wtf/text/StringImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58541088774d456774a1aedb16b7b0038e129786 commit 58541088774d456774a1aedb16b7b0038e129786 Author: thakis <thakis@chromium.org> Date: Mon May 08 17:12:15 2017 Remove ENABLE(INSTANCE_COUNTER) code. It's been unused for a while. (While this removes platform/wtf/InstanceCounter.h, platform/InstanceCounters.h remains.) BUG=675877 Review-Url: https://codereview.chromium.org/2872613002 Cr-Commit-Position: refs/heads/master@{#470027} [modify] https://crrev.com/58541088774d456774a1aedb16b7b0038e129786/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/58541088774d456774a1aedb16b7b0038e129786/third_party/WebKit/Source/core/testing/Internals.h [modify] https://crrev.com/58541088774d456774a1aedb16b7b0038e129786/third_party/WebKit/Source/core/testing/Internals.idl [modify] https://crrev.com/58541088774d456774a1aedb16b7b0038e129786/third_party/WebKit/Source/platform/wtf/BUILD.gn [delete] https://crrev.com/f42a25f36d9ae587b3b8f2c584c4c3075cc24f2f/third_party/WebKit/Source/platform/wtf/InstanceCounter.cpp [delete] https://crrev.com/f42a25f36d9ae587b3b8f2c584c4c3075cc24f2f/third_party/WebKit/Source/platform/wtf/InstanceCounter.h [modify] https://crrev.com/58541088774d456774a1aedb16b7b0038e129786/third_party/WebKit/Source/platform/wtf/RefCounted.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3630a887246154e36ec543cc5645f449a704837 commit f3630a887246154e36ec543cc5645f449a704837 Author: thakis <thakis@chromium.org> Date: Mon May 08 17:54:24 2017 Manually convert ScreenWakeLockTest.cpp to new blink style. BUG=675877 Review-Url: https://codereview.chromium.org/2868863002 Cr-Commit-Position: refs/heads/master@{#470044} [modify] https://crrev.com/f3630a887246154e36ec543cc5645f449a704837/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c0e369d74f4406b82fcb38581cd1a1abf3d7559 commit 4c0e369d74f4406b82fcb38581cd1a1abf3d7559 Author: thakis <thakis@chromium.org> Date: Mon May 08 20:53:05 2017 Manually convert VisualViewportTest.cpp to new blink style. BUG=675877 NOTRY=true Review-Url: https://codereview.chromium.org/2871603002 Cr-Commit-Position: refs/heads/master@{#470118} [modify] https://crrev.com/4c0e369d74f4406b82fcb38581cd1a1abf3d7559/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f33458f42d4dc333d684b1c7ac62ded430f1532 commit 9f33458f42d4dc333d684b1c7ac62ded430f1532 Author: lukasza <lukasza@chromium.org> Date: Tue May 09 14:05:34 2017 Blink rename follow-up: Use Chromium style in network_instrumentation namespace. Clang-based renaming tool only processed idenfitiers within blink and WTF namespaces and so it has skipped top-level network_instrumentation namespace in platform/network/NetworkInstrumentation.h This CL applies Chromium style to the network_instrumentation namespace and nests this namespace into the blink namespace. This CL was partially generated using the clang-based renaming tool. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2868923002 Cr-Commit-Position: refs/heads/master@{#470316} [modify] https://crrev.com/9f33458f42d4dc333d684b1c7ac62ded430f1532/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [modify] https://crrev.com/9f33458f42d4dc333d684b1c7ac62ded430f1532/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp [modify] https://crrev.com/9f33458f42d4dc333d684b1c7ac62ded430f1532/third_party/WebKit/Source/platform/network/NetworkInstrumentation.cpp [modify] https://crrev.com/9f33458f42d4dc333d684b1c7ac62ded430f1532/third_party/WebKit/Source/platform/network/NetworkInstrumentation.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef4ebca63735c859ed586a2f4a552d1df21c6d3a commit ef4ebca63735c859ed586a2f4a552d1df21c6d3a Author: Nico Weber <thakis@chromium.org> Date: Tue May 09 14:59:28 2017 blink: m_foo -> foo_ in logging strings. No behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 R=dcheng@chromium.org Review-Url: https://codereview.chromium.org/2866093002 . Cr-Commit-Position: refs/heads/master@{#470333} [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/core/html/HTMLMediaElement.h [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/core/loader/ImageLoader.cpp [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/core/paint/PaintLayer.h [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/platform/audio/PushPullFIFO.cpp [modify] https://crrev.com/ef4ebca63735c859ed586a2f4a552d1df21c6d3a/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d714f13fdb739bb89cf75ec606312d56b0d3d590 commit d714f13fdb739bb89cf75ec606312d56b0d3d590 Author: thakis <thakis@chromium.org> Date: Tue May 09 20:23:29 2017 PaintLayerClipper: Remove CHECK_CLIP_RECTS build mode. The code guarded by this macro hasn't been compiling for a while now. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2868073002 Cr-Commit-Position: refs/heads/master@{#470415} [modify] https://crrev.com/d714f13fdb739bb89cf75ec606312d56b0d3d590/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/932bc10e78854ff0191e9e6b0afa8bf0b370c419 commit 932bc10e78854ff0191e9e6b0afa8bf0b370c419 Author: lukasza <lukasza@chromium.org> Date: Wed May 10 04:08:28 2017 Blink rename follow-up: No more |m_...| field names in ADD_BOOLEAN_BITFIELD. It was impossible for the clang-based renaming tool to rename identifiers where the renamed identifier was crossing boundaries of macro token##concatenation - this left some fields named using the |m_oldBlinkStyle|. This CL tweaks the ADD_BOOLEAN_BITFIELD macro, so that it uses new_style_ field names rather than m_oldStyle names. I've also tweaked some comments to refer to the new names. This CL has been mostly generated semi-automatically with the help of editor macros. No intended behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2864033003 Cr-Commit-Position: refs/heads/master@{#470447} [modify] https://crrev.com/932bc10e78854ff0191e9e6b0afa8bf0b370c419/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/932bc10e78854ff0191e9e6b0afa8bf0b370c419/third_party/WebKit/Source/core/layout/line/InlineBox.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb282bdd726c1dc16ec415b2267d08d2ce3248e6 commit cb282bdd726c1dc16ec415b2267d08d2ce3248e6 Author: thakis <thakis@chromium.org> Date: Wed May 10 04:46:12 2017 m_foo -> foo_ in SettingsMacros, and fix DEBUG_TEXT_AUTOSIZING_ON_DESKTOP build. No behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2870113002 Cr-Commit-Position: refs/heads/master@{#470457} [modify] https://crrev.com/cb282bdd726c1dc16ec415b2267d08d2ce3248e6/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl [modify] https://crrev.com/cb282bdd726c1dc16ec415b2267d08d2ce3248e6/third_party/WebKit/Source/core/frame/Settings.cpp [modify] https://crrev.com/cb282bdd726c1dc16ec415b2267d08d2ce3248e6/third_party/WebKit/Source/web/WebSettingsImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67d309c494ff65745c436e46e4ed7c3095b07d8a commit 67d309c494ff65745c436e46e4ed7c3095b07d8a Author: thakis <thakis@chromium.org> Date: Thu May 11 19:34:56 2017 Rewrite three more classes to new blink style. No behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2875703003 Cr-Commit-Position: refs/heads/master@{#471044} [modify] https://crrev.com/67d309c494ff65745c436e46e4ed7c3095b07d8a/third_party/WebKit/Source/platform/fonts/VDMXParser.cpp [modify] https://crrev.com/67d309c494ff65745c436e46e4ed7c3095b07d8a/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp [modify] https://crrev.com/67d309c494ff65745c436e46e4ed7c3095b07d8a/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp [modify] https://crrev.com/67d309c494ff65745c436e46e4ed7c3095b07d8a/third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.cpp [modify] https://crrev.com/67d309c494ff65745c436e46e4ed7c3095b07d8a/third_party/WebKit/Source/platform/graphics/test/FakeGLES2Interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6aa511064b40136b0bf83d926690898b285f114 commit c6aa511064b40136b0bf83d926690898b285f114 Author: thakis <thakis@chromium.org> Date: Thu May 11 22:27:59 2017 Remove DEBUG_TEXT_AUTOSIZING_ON_DESKTOP altogether. Autosizing can be triggered through devtools on desktop nowadays. BUG=675877 Review-Url: https://codereview.chromium.org/2874783003 Cr-Commit-Position: refs/heads/master@{#471090} [modify] https://crrev.com/c6aa511064b40136b0bf83d926690898b285f114/third_party/WebKit/Source/core/frame/Settings.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4097d86ffef927e2d617a07e4bee2ad9ec31cbc commit f4097d86ffef927e2d617a07e4bee2ad9ec31cbc Author: thakis <thakis@chromium.org> Date: Thu May 11 22:49:50 2017 Remove dead macros BUG=675877, 720442 Review-Url: https://codereview.chromium.org/2872273004 Cr-Commit-Position: refs/heads/master@{#471100} [modify] https://crrev.com/f4097d86ffef927e2d617a07e4bee2ad9ec31cbc/third_party/WebKit/Source/platform/wtf/PrintStream.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e56e395b65eb473d5f0814a8e870e75632c76229 commit e56e395b65eb473d5f0814a8e870e75632c76229 Author: thakis <thakis@chromium.org> Date: Thu May 11 23:08:37 2017 blink: Remove CHECK_CONSISTENCY. This conditional build mode was added almost a decade ago in http://bugs.webkig.org/show_bug.cgi?id=14981 and the code guarded by it hasn't been compiling in a few weeks at least. It's probably safe to say that it hasn't been used in a long time. BUG=675877 Review-Url: https://codereview.chromium.org/2871983002 Cr-Commit-Position: refs/heads/master@{#471111} [modify] https://crrev.com/e56e395b65eb473d5f0814a8e870e75632c76229/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/e56e395b65eb473d5f0814a8e870e75632c76229/third_party/WebKit/Source/core/layout/LayoutText.h [modify] https://crrev.com/e56e395b65eb473d5f0814a8e870e75632c76229/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp [modify] https://crrev.com/e56e395b65eb473d5f0814a8e870e75632c76229/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h [modify] https://crrev.com/e56e395b65eb473d5f0814a8e870e75632c76229/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp [modify] https://crrev.com/e56e395b65eb473d5f0814a8e870e75632c76229/third_party/WebKit/Source/core/layout/line/LineBoxList.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9601a9bbabcf3aad7d64f0d192561dc80dd374c2 commit 9601a9bbabcf3aad7d64f0d192561dc80dd374c2 Author: thakis <thakis@chromium.org> Date: Fri May 12 00:17:23 2017 Remove DEBUG_DOM_PATCH_SUPPORT The code guarded by it hasn't been compiling for a while, and this code was added over 5 years ago. It probably isn't used any longer. BUG=675877 Review-Url: https://codereview.chromium.org/2869953003 Cr-Commit-Position: refs/heads/master@{#471136} [modify] https://crrev.com/9601a9bbabcf3aad7d64f0d192561dc80dd374c2/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp [modify] https://crrev.com/9601a9bbabcf3aad7d64f0d192561dc80dd374c2/third_party/WebKit/Source/core/inspector/DOMPatchSupport.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/459731e7f4376e99d785ac7b0d40622747ca318e commit 459731e7f4376e99d785ac7b0d40622747ca318e Author: thakis <thakis@chromium.org> Date: Fri May 12 00:29:41 2017 blink style: Update one class cluster, delete one class, change comment style. The C-style comments were confusing a regex. No behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2872133004 Cr-Commit-Position: refs/heads/master@{#471142} [modify] https://crrev.com/459731e7f4376e99d785ac7b0d40622747ca318e/third_party/WebKit/Source/platform/heap/WrapperVisitor.h [modify] https://crrev.com/459731e7f4376e99d785ac7b0d40622747ca318e/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp [modify] https://crrev.com/459731e7f4376e99d785ac7b0d40622747ca318e/third_party/WebKit/Source/platform/text/LineEnding.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05c3beef96190eae64f7a265d63fe17e380af97d commit 05c3beef96190eae64f7a265d63fe17e380af97d Author: drott <drott@chromium.org> Date: Fri May 12 18:00:14 2017 blink style: Update BidiTestHarness bidi_test namespace != blink namespace, fixed by temporarily changing the namespace and running the renaming tool again. BUG=675877 Review-Url: https://codereview.chromium.org/2879903002 Cr-Commit-Position: refs/heads/master@{#471363} [modify] https://crrev.com/05c3beef96190eae64f7a265d63fe17e380af97d/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp [modify] https://crrev.com/05c3beef96190eae64f7a265d63fe17e380af97d/third_party/WebKit/Source/platform/text/BidiTestHarness.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de0ad0210a83a3c2bf721f561b4a1df76ff55e10 commit de0ad0210a83a3c2bf721f561b4a1df76ff55e10 Author: cvazac <cvazac@akamai.com> Date: Sat May 13 16:48:05 2017 rename PerformanceServerTiming members to conform with 'Blink Rename' BUG=675877 Review-Url: https://codereview.chromium.org/2880873002 Cr-Commit-Position: refs/heads/master@{#471586} [modify] https://crrev.com/de0ad0210a83a3c2bf721f561b4a1df76ff55e10/third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp [modify] https://crrev.com/de0ad0210a83a3c2bf721f561b4a1df76ff55e10/third_party/WebKit/Source/core/timing/PerformanceServerTiming.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e333a8b374879c60efc4a8c6c699487b52b138e commit 2e333a8b374879c60efc4a8c6c699487b52b138e Author: Daniel Cheng <dcheng@chromium.org> Date: Wed May 17 06:47:29 2017 Convert GIFImageReader to use updated Blink style. GIFImageReader and its support classes weren't in the Blink namespace, so the automated rewrite missed them. As incidental cleanup, this CL also removes some unnecessary macros. Bug: 675877 Change-Id: I635ff17cd2d360d676a92552ec4ee992ae8d7855 Reviewed-on: https://chromium-review.googlesource.com/505284 Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#472357} [modify] https://crrev.com/2e333a8b374879c60efc4a8c6c699487b52b138e/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp [modify] https://crrev.com/2e333a8b374879c60efc4a8c6c699487b52b138e/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h [modify] https://crrev.com/2e333a8b374879c60efc4a8c6c699487b52b138e/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp [modify] https://crrev.com/2e333a8b374879c60efc4a8c6c699487b52b138e/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h
Comment 1 by dcheng@chromium.org
, Dec 20 2016