After this patch db78e67f2c47c3b2e7bd548d9d1a4e4f1b3124e4, Quota.QuotaForOrigin UMA has gone to almost zero. This means almost all sites can't use CacheStorage, IndexedDB, ServiceWorker, etc... I think the restriction which was introduced by the patch is too tight. $ git find-releases db78e67f2c47c3b2e7bd548d9d1a4e4f1b3124e4 commit db78e67f2c47c3b2e7bd548d9d1a4e4f1b3124e4 was: initially in 57.0.2953.0
Interesting - we expected this change to generally increase quota available. We should revert...
Issue 675945 has been merged into this issue.
I'm assuming https://codereview.chromium.org/2581733002 didn't fix it.
The Quota.AvailableDiskSpace graph dropped off too, although Quota.TotalDiskSpace increased. Something must be wonky on those calculations.
https://codereview.chromium.org/2592793002 is CL for revert.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26ccaa7865154cadca323a7d38ea2482a42f654b commit 26ccaa7865154cadca323a7d38ea2482a42f654b Author: jsbell <jsbell@chromium.org> Date: Wed Dec 21 13:09:05 2016 Revert of Change how the quota system computes the total poolsize for temporary storage Seems to have negatively impacted quota allocation. Original CL: https://codereview.chromium.org/1782053004/ Original Committed: https://crrev.com/db78e67f2c47c3b2e7bd548d9d1a4e4f1b3124e4 Original Cr-Commit-Position: refs/heads/master@{#438741} BUG= 520318 , 675875 R=cmumford@chromium.org TBR=isherman@chromium.org Review-Url: https://codereview.chromium.org/2592793002 Cr-Commit-Position: refs/heads/master@{#440079} [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/android_webview/browser/DEPS [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/android_webview/browser/aw_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/ash/shell/content/client/DEPS [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/ash/shell/content/client/shell_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/ash/shell/content/client/shell_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/base/time/time.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/base/time/time.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/blimp/engine/DEPS [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/blimp/engine/app/blimp_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/blimp/engine/app/blimp_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/BUILD.gn [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/chrome_content_browser_client.h [add] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/engagement/site_engagement_eviction_policy.cc [add] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/engagement/site_engagement_eviction_policy.h [add] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/engagement/site_engagement_eviction_policy_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/engagement/site_engagement_service.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/extension_special_storage_policy.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/extension_special_storage_policy.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/extension_storage_monitor.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/mock_extension_special_storage_policy.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/extensions/mock_extension_special_storage_policy.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/ui/webui/quota_internals/quota_internals_proxy.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/browser/ui/webui/quota_internals/quota_internals_proxy.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/test/BUILD.gn [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/test/DEPS [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chrome/test/base/in_process_browser_test.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/chromecast/browser/cast_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/appcache/appcache_host_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/appcache/appcache_storage_impl_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/background_sync/background_sync_manager_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/background_sync/background_sync_service_impl_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/browsing_data/clear_site_data_throttle_browsertest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/database_tracker_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/fileapi/file_system_browsertest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/fileapi/obfuscated_file_util_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/indexed_db/indexed_db_browsertest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/payments/payment_app_content_unittest_base.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/mock_quota_manager.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/mock_quota_manager.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/mock_quota_manager_proxy.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/mock_quota_manager_proxy.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/quota_backend_impl_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/quota_manager_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/quota_temporary_storage_evictor_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/quota/storage_monitor_unittest.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/storage_partition_impl.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/storage_partition_impl.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/browser/storage_partition_impl_map.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/public/browser/BUILD.gn [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/public/browser/content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/public/browser/content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/public/test/mock_special_storage_policy.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/public/test/mock_special_storage_policy.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/shell/browser/layout_test/layout_test_browser_main_parts.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/shell/browser/layout_test/layout_test_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/shell/browser/layout_test/layout_test_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/shell/browser/layout_test/layout_test_message_filter.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/test/test_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/content/test/test_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/extensions/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/extensions/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/extensions/shell/browser/shell_special_storage_policy.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/extensions/shell/browser/shell_special_storage_policy.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/headless/lib/browser/DEPS [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/headless/lib/browser/headless_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/headless/lib/browser/headless_content_browser_client.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/BUILD.gn [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/client_usage_tracker.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/client_usage_tracker.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/quota_manager.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/quota_manager.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/quota_manager_proxy.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/quota_manager_proxy.h [delete] https://crrev.com/6661c527f2cc07652b208e05afd07b79baf58301/storage/browser/quota/quota_settings.cc [delete] https://crrev.com/6661c527f2cc07652b208e05afd07b79baf58301/storage/browser/quota/quota_settings.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/quota_temporary_storage_evictor.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/quota_temporary_storage_evictor.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/special_storage_policy.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/usage_tracker.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/storage/browser/quota/usage_tracker.h [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/ui/views_content_client/DEPS [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/ui/views_content_client/views_content_browser_client.cc [modify] https://crrev.com/26ccaa7865154cadca323a7d38ea2482a42f654b/ui/views_content_client/views_content_browser_client.h
Thnx for reverting :(
+1, things work for me now!
jsbell@: If there is no work to be done here, could you please close the issue.
Thanks for the reminder.
Comment 1 by horo@chromium.org
, Dec 20 2016