Checkmarks are not clear. We should badge icons with green circle instead, e.g. like in the screenshot.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/911cf4b74f6dbce780c83e31b51358bb2c849416 commit 911cf4b74f6dbce780c83e31b51358bb2c849416 Author: lushnikov <lushnikov@chromium.org> Date: Tue Dec 20 16:57:48 2016 DevTools: teach TabbedPane.setTabIcon to accept UI.Icon instances This patch is a preparation for a "badged icons" instead of green checkmarks in the "persistence2" experiment. Currently, TabbedPane.setTabIcon method accepts icon type and icon titles. This works fine, but we'd like to pass in a more complex objects - badged icons. For this to work, the TabbedPane.setTabIcon has to accept general instances of UI.Icon class. BUG= 675856 R=dgozman Review-Url: https://codereview.chromium.org/2587293002 Cr-Commit-Position: refs/heads/master@{#439828} [modify] https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416/third_party/WebKit/Source/devtools/front_end/main/Main.js [modify] https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js [modify] https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js [modify] https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js [modify] https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js [modify] https://crrev.com/911cf4b74f6dbce780c83e31b51358bb2c849416/third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bf007fcb5625e6e883570fd9eeca7b2594ac85d commit 6bf007fcb5625e6e883570fd9eeca7b2594ac85d Author: lushnikov <lushnikov@chromium.org> Date: Wed Dec 21 20:06:35 2016 DevTools: [Persistence] introduce badged icons instead of checkmarks This patch introduces badged icons instead of green checkmarks. To achieve this, this CL does: - introduce a bunch of new icons - introduce UI.Icon.combine method, which overlays an array of icons atop of each other. The result of this operation is a span which has dimensions of the first icon. BUG= 675856 R=dgozman Review-Url: https://codereview.chromium.org/2594883002 Cr-Commit-Position: refs/heads/master@{#440194} [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/src/smallIcons.svg [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs.png [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/ui/Icon.js [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css [modify] https://crrev.com/6bf007fcb5625e6e883570fd9eeca7b2594ac85d/third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css
Comment 1 by bugdroid1@chromium.org
, Dec 20 2016