New issue
Advanced search Search tips

Issue 675846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Improve smoothness display stats on CrOS

Reported by zheda.c...@intel.com, Dec 20 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36
Platform: 9086.0.0 (official build) dev-channel cyan test

Steps to reproduce the problem:
1. cd src/tools/perf/
2. Run "run_benchmark --remote=<CrOS_ip> --browser=cros-chrome smoothness.top_25_smooth"
3. check results.html

What is the expected behavior?

What went wrong?
Currently smoothness frame rate metrics on CrOS is based on compositor timestamps, not when it becomes visible on screen, thus less accurate than android SurfaceFlinger based metrics.

Did this work before? N/A 

Chrome version: 57.0.2951.0  Channel: dev
OS Version: 9086.0.0
Flash Version: 24.0.0.174

In ozone, page flip completion event has a timestamp from kernel, which is the exact time the page flip happened. It helps to improve smoothness display stats on CrOS. We can replace compositor timestamp data with more accurate page flip timestamp data.
 
I have submitted two patches related. Please take a look.
Review URL: 
  https://codereview.chromium.org/2593513002/
  https://codereview.chromium.org/2594573002/
Components: -Platform>DevTools
Status: Untriaged (was: Unconfirmed)
Removing DevTools component
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/433217209fecf0efddb8f511b74c749d3a55709b

commit 433217209fecf0efddb8f511b74c749d3a55709b
Author: zheda.chen <zheda.chen@intel.com>
Date: Tue Jan 24 05:44:18 2017

Add page flip completion event to trace on CrOS

This patch adds CrOS page flip completion event to trace. The event has a timestamp
in data field, which is the exact time the page flip happened. It will be used to
improve smoothness display stats accuracy on CrOS.

BUG= 675846 

Review-Url: https://codereview.chromium.org/2593513002
Cr-Commit-Position: refs/heads/master@{#445659}

[modify] https://crrev.com/433217209fecf0efddb8f511b74c749d3a55709b/AUTHORS
[modify] https://crrev.com/433217209fecf0efddb8f511b74c749d3a55709b/ui/ozone/platform/drm/gpu/drm_device.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3b4a2f32560ad82a6892a93f64bb260def54c51

commit c3b4a2f32560ad82a6892a93f64bb260def54c51
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Jan 26 20:04:33 2017

Roll src/third_party/catapult/ e1e778d78..7a2a837ac (29 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e1e778d78de1..7a2a837ac3ae

$ git log e1e778d78..7a2a837ac --date=short --no-merges --format='%ad %ae %s'
2017-01-26 benjhayden Translate RelatedHistogramSet to python.
2017-01-26 benjhayden Translate RelatedEventSet to python.
2017-01-26 yolandyan Revert of Change apk_helper.py for apk with multi instrumentations and JUnit4 (patchset #10 id:180001 of https://codereview.chromium.org/2632763003/ )
2017-01-26 nednguyen Update labels to tag in story_set_smoke_test
2017-01-26 hjd [tracing] Cache number formatters in Unit
2017-01-25 dtu [pinpoint] RunTest (Swarming) Quest and Execution.
2017-01-25 charliea Set DISABLE_CLOUD_STORAGE_IO back after psuedo lock tests
2017-01-25 alexandermont Make the whole story power metric not depend on Chrome trace.
2017-01-25 benjhayden Fix TelemetryInfo.
2017-01-25 benjhayden Redesign breakdown-span.
2017-01-25 benjhayden Translate DeviceInfo to python.
2017-01-25 benjhayden Translate TelemetryInfo to python.
2017-01-25 benjhayden Allow metrics to resegment the UserModel.
2017-01-25 benjhayden Translate BuildbotInfo to python.
2017-01-24 simonhatch Dashboard - Remove some old queues.
2017-01-24 sullivan Add ref build back into charts on /group_report page.
2017-01-24 benjhayden Translate Diagnostics to Python.
2017-01-24 benjhayden Make trace2html accept gzipped trace json files in addition to unzipped files.
2017-01-24 benjhayden Add Segments to the UserModel.
2017-01-24 alexandermont Fix function scope bug in tquery.
2017-01-24 charliea Fix bug where stale lock file can cause cloud storage timeouts
2017-01-24 benjhayden Improve BarChart and ColumnChart hover boxes.
2017-01-24 yolandyan Change apk_helper.py for apk with multi instrumentations and JUnit4
2017-01-24 kbr Only display 200 lines of syslog upon sub-process crash on macOS.
2017-01-24 kraynov Fix wrong upload of memtrack_helper for arm64 CPU.
2017-01-23 zheda.chen Change smoothness frame-times metrics on CrOS
2017-01-23 benjhayden Delete systemHealthMetrics meta-metric.
2017-01-23 simonhatch Dashboard - Fix output when tests fail to produce output.
2017-01-23 nednguyen [Telemetry] Remove labels field from story.Story constructor & labels related flags

BUG= 682005 , 682005 , 682819 ,672780, 675846 , 683998 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2654253003
Cr-Commit-Position: refs/heads/master@{#446416}

[modify] https://crrev.com/c3b4a2f32560ad82a6892a93f64bb260def54c51/DEPS

Status: Fixed (was: Untriaged)

Sign in to add a comment