New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675841 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Grouped History] Add routing support

Project Member Reported by tsergeant@chromium.org, Dec 20 2016

Issue description

The following routes should work for grouped history:

/history/week
/history/month
/history/week?q=search&offset=2
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91b05c8bdccd7ffc19047ab04e8a5790976eaebc

commit 91b05c8bdccd7ffc19047ab04e8a5790976eaebc
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Jan 23 00:27:03 2017

MD History: Move querying logic to new <history-query-manager> element

This moves most of the logic related to querying the history backend
into a new element. This makes it simpler to manage updates to the query,
and is the first step in allowing updates to grouped queries to be
reflected to the page URL.

BUG= 675841 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2590093002
Cr-Commit-Position: refs/heads/master@{#445305}

[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/browser_resources.grd
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/list_container.js
[add] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/query_manager.html
[add] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/query_manager.js
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/resources/md_history/router.js
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/91b05c8bdccd7ffc19047ab04e8a5790976eaebc/chrome/test/data/webui/md_history/history_list_test.js

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222

commit b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Jan 23 22:56:26 2017

MD History: Use one-way binding for history query state.

Instead of changing query state anywhere within the history code,
elements now fire an event containing the changes they want to make.
This is picked up by the query-manager and used to modify the page state
as needed. Any UI changes will then flow down through the page using
one-way binding.

This pattern further centralises the querying logic, decoupling it from
the UI state. It also adds the capability to make multiple changes to
the query state at once, which is necessary to support routing for
Grouped History.

BUG= 675841 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2643533003
Cr-Commit-Position: refs/heads/master@{#445526}

[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/history_toolbar.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/list_container.html
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/query_manager.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/browser/resources/md_history/router.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/test/data/webui/md_history/history_grouped_list_test.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/test/data/webui/md_history/history_metrics_test.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/test/data/webui/md_history/history_routing_test.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/test/data/webui/md_history/history_toolbar_test.js
[modify] https://crrev.com/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222/chrome/test/data/webui/md_history/test_util.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2112ddfabe748e6a6a6f9fdbb7de7ade58326957

commit 2112ddfabe748e6a6a6f9fdbb7de7ade58326957
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Jan 30 03:42:08 2017

MD History: Add routing for grouped history mode.

This adds routes of the form `chrome://history/history/week?offset=1`
to grouped MD History. When grouped history is not enabled, these routes
are ignored.

This CL also enables (grouped) MD History when the
--enable-grouped-history flag is present.

BUG= 675841 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2656443004
Cr-Commit-Position: refs/heads/master@{#446955}

[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/grouped_list.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/history_list_behavior.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/history_toolbar.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/lazy_load.crisper.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/list_container.html
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/query_manager.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/router.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/test/data/webui/md_history/history_routing_test.js
[modify] https://crrev.com/2112ddfabe748e6a6a6f9fdbb7de7ade58326957/chrome/test/data/webui/md_history/md_history_browsertest.js

Status: Fixed (was: Started)

Sign in to add a comment