New issue
Advanced search Search tips

Issue 675818 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

[Windows][Host] Remove DCHECKs in security key IPC client class

Project Member Reported by joedow@chromium.org, Dec 20 2016

Issue description

Per discussion with DCheng, make IPC interface resilient against IPC ordering problems.
 

Comment 1 by joedow@chromium.org, Dec 22 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d383cc3285b2d20ed583d74a50f6dc019dc8bb3a

commit d383cc3285b2d20ed583d74a50f6dc019dc8bb3a
Author: joedow <joedow@chromium.org>
Date: Fri Dec 23 00:39:20 2016

Update IPC message handling for SecurityKeyIpcClient class

Per discussion with DCheng, we should not be DCHECK'ing if we receive
the connection IPC message out of order or when not expected.  This
change will now call the error callback if this situation occurs which
will gracefully close the IPC connection.  I've also added unit tests
for these scenarios.

BUG= 675818 

Review-Url: https://codereview.chromium.org/2596393002
Cr-Commit-Position: refs/heads/master@{#440563}

[modify] https://crrev.com/d383cc3285b2d20ed583d74a50f6dc019dc8bb3a/remoting/host/security_key/security_key_ipc_client.cc
[modify] https://crrev.com/d383cc3285b2d20ed583d74a50f6dc019dc8bb3a/remoting/host/security_key/security_key_ipc_client_unittest.cc

Comment 3 by joedow@chromium.org, Dec 23 2016

Status: Fixed (was: Started)

Sign in to add a comment