[Windows][Host] Remove DCHECKs in security key IPC client class |
||
Issue descriptionPer discussion with DCheng, make IPC interface resilient against IPC ordering problems.
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d383cc3285b2d20ed583d74a50f6dc019dc8bb3a commit d383cc3285b2d20ed583d74a50f6dc019dc8bb3a Author: joedow <joedow@chromium.org> Date: Fri Dec 23 00:39:20 2016 Update IPC message handling for SecurityKeyIpcClient class Per discussion with DCheng, we should not be DCHECK'ing if we receive the connection IPC message out of order or when not expected. This change will now call the error callback if this situation occurs which will gracefully close the IPC connection. I've also added unit tests for these scenarios. BUG= 675818 Review-Url: https://codereview.chromium.org/2596393002 Cr-Commit-Position: refs/heads/master@{#440563} [modify] https://crrev.com/d383cc3285b2d20ed583d74a50f6dc019dc8bb3a/remoting/host/security_key/security_key_ipc_client.cc [modify] https://crrev.com/d383cc3285b2d20ed583d74a50f6dc019dc8bb3a/remoting/host/security_key/security_key_ipc_client_unittest.cc
,
Dec 23 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by joedow@chromium.org
, Dec 22 2016