Make suspend/resume renderer workable with memory coordinator |
||||
Issue descriptionJust calling SuspendRenderer() and ResumeRenderer() in RenderThreadImpl::OnMemoryStateChange() breaks many things. We should have consistent and reliable logic to suspend/resume renderers with memory coordinator. For now, I'm going to disable suspending renderers.
,
Dec 20 2016
,
Dec 20 2016
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1536fd7e1fa4dd7559e2c12e290e79cf949e9fe commit b1536fd7e1fa4dd7559e2c12e290e79cf949e9fe Author: bashi <bashi@chromium.org> Date: Tue Dec 20 04:49:30 2016 Disable suspending renderer when memory coordinator is enabled Just calling SuspendRenderer() in OnMemoryStateChange() breaks many things. We need a reliable and consistent way to suspend renderers. Until we come up with a solution, disable renderer suspending when memory coordinator is enabled. In follow-up CLs I'll add some tests to prevent this kind of regressions. BUG= 675735 , 675811 Review-Url: https://codereview.chromium.org/2590073002 Cr-Commit-Position: refs/heads/master@{#439708} [modify] https://crrev.com/b1536fd7e1fa4dd7559e2c12e290e79cf949e9fe/content/renderer/render_thread_impl.cc
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d37e4c892eed8e2ad96de67f347254b846531ede commit d37e4c892eed8e2ad96de67f347254b846531ede Author: bashi <bashi@chromium.org> Date: Tue Dec 20 10:41:28 2016 Use MockRenderProcessHost in memory coordinator unittests Calling RenderProcessHost::FromID() directly prevents us to write unittests. Add a virtual method for getting RenderProcessHost so that testing code can use MockRenderProcessHost to write unittests. Also, this CL installs a MemoryCoordinatorDelegate in unittests so that unittests can have wider coverage. BUG= 675811 Review-Url: https://codereview.chromium.org/2594513002 Cr-Commit-Position: refs/heads/master@{#439764} [modify] https://crrev.com/d37e4c892eed8e2ad96de67f347254b846531ede/content/browser/memory/memory_coordinator_impl.cc [modify] https://crrev.com/d37e4c892eed8e2ad96de67f347254b846531ede/content/browser/memory/memory_coordinator_impl.h [modify] https://crrev.com/d37e4c892eed8e2ad96de67f347254b846531ede/content/browser/memory/memory_coordinator_impl_unittest.cc
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff1e6242e014db17e8bb736741595705c81dc774 commit ff1e6242e014db17e8bb736741595705c81dc774 Author: tasak <tasak@google.com> Date: Thu Dec 22 04:53:55 2016 Disable PurgeAndSuspend when MemoryCoordinator is enabled. PurgeAndSuspend depends on OnMemoryStateChange(). However, always suspending renderer in OnMemoryStateChange(), it breaks many things. So only enabling such suspend / resume feature when only PurgeAndSuspend is enabled. BUG= 675735 , 675811 Review-Url: https://codereview.chromium.org/2595813002 Cr-Commit-Position: refs/heads/master@{#440340} [modify] https://crrev.com/ff1e6242e014db17e8bb736741595705c81dc774/content/renderer/render_thread_impl.cc
,
Feb 28 2017
Let me close this as we don't intend to suspend at this point. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bashi@chromium.org
, Dec 20 2016