New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675792 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocked on:
issue 676278
issue 677941



Sign in to add a comment

Cleanups after upstreaming

Project Member Reported by rohitrao@chromium.org, Dec 20 2016

Issue description

Umbrella bug for some or all of the following:
- merge foo and foo_internal targets.  also for unittests
- remove use_ios_internal_provider and provider.gni
- remove the ios_internal namespace upstream
- move things into ios_internal downstream
- move code back out of chrome/browser/providers
- Merge DownstreamBrowserProvider into ChromiumBrowserProvider
- add a gn variable for "extra_eg_test_targets" to use for the flaky and multitasking suites
- verify that all unittests were properly added to ios_chrome_unittests by comparing the passed test lists
- fix voice search icons in Chromium
- fix json bot configs to add additional_compile_targets back downstream
- delete downstream DEPS and OWNERS files
 
- Fix entitlements for EG tests that use the share extension
- Figure out if we can remove "chromium" simulator tests from the downstream waterfall (base, net, etc)
Re #2, point 2, I should probably keep the device version of those tests until we have upstream device bots.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f9b4cfbccf32ba65dfff462d9798e673324fdc84

commit f9b4cfbccf32ba65dfff462d9798e673324fdc84
Author: rohitrao <rohitrao@google.com>
Date: Tue Dec 20 13:29:16 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ee6bfc994aaf33eff0597f0878b70d8d67bc16bd

commit ee6bfc994aaf33eff0597f0878b70d8d67bc16bd
Author: sdefresne <sdefresne@google.com>
Date: Tue Dec 20 13:31:04 2016

Blockedon: 676278
I suggest we create sub-issues for each points that need tracking.

I've claimed https://bugs.chromium.org/p/chromium/issues/detail?id=676278 to "Merge DownstreamBrowserProvider into ChromiumBrowserProvider".
Blockedon: 677941
 Issue 677941  for:
- remove the ios_internal namespace upstream
Components: Internals
Labels: -Type-Bug Type-Task
Labels: Hotlist-TechnicalDebt

Sign in to add a comment