New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675786 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
mea...@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Safe Browsing interstitial page double-counts DontProceed

Project Member Reported by jialiul@chromium.org, Dec 20 2016 
How to reproduce:
(1) go to testsafebrowsing.appspot.com
(2) clicks on interstitial test link
(3) go back to previous page by using the arrow next to address bar or close the tab
(4) on chrome://histograms  interstitial.malware/phishing/harmful.decision increases by 1 on Show, increases by 2 on DontProceed

DontProceed should only increase by 1.

Comment 1 by jialiul@chromium.org, Dec 20 2016 

BTW, "Back to safety" button on the interstitial page WAI.

Comment 2 by nparker@chromium.org, Dec 20 2016

Cc: mea...@chromium.org

Comment 3 by mea...@chromium.org, Dec 20 2016 

Nice find. Filed bug 675807 to write tests for interstitial histograms.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f322ce5c257661c75c178315db05f342dec57c

commit 19f322ce5c257661c75c178315db05f342dec57c
Author: jialiul <jialiul@chromium.org>
Date: Tue Dec 20 02:22:25 2016

Remove duplicated UMA recording when destructing SafeBrowsingErrorUI.
Unlike SSL interstitial, when destructing safe browsing interstitial,
SafeBrowsingBlockingPage::OnDontProceed() function gets called. This
function takes cares of recording the DONT_PROCEED action. Therefore,
no need to recording DONT_PROCEED in SafeBrowsingErrorUI's destructor.

BUG= 675786 

Review-Url: https://codereview.chromium.org/2594453002
Cr-Commit-Position: refs/heads/master@{#439672}

[modify] https://crrev.com/19f322ce5c257661c75c178315db05f342dec57c/components/security_interstitials/core/safe_browsing_error_ui.cc
[modify] https://crrev.com/19f322ce5c257661c75c178315db05f342dec57c/components/security_interstitials/core/safe_browsing_error_ui.h

Comment 5 by jialiul@chromium.org, Dec 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment