New issue
Advanced search Search tips

Issue 675776 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 432934


Sign in to add a comment

Refactor AudioParamTimeline::valuesForFrameRangeImpl

Project Member Reported by rtoy@chromium.org, Dec 19 2016 
This 762-line function needs to be refactored into smaller parts.  At the very least, each individual case for each event type could probably be in it's own function.

Comment 1 Deleted

Comment 2 by rtoy@chromium.org, Dec 20 2016

Blockedon: 432934
Do the refactoring after  issue 432934  (cancel and hold) has landed.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abcc1f5eb8bb22bd603342f951dbd076c8491d3b

commit abcc1f5eb8bb22bd603342f951dbd076c8491d3b
Author: rtoy <rtoy@chromium.org>
Date: Wed Feb 15 00:39:08 2017

Refactor valuesForFrameRangeImpl

This function is 766 lines long with complicated logic.  Move each
core subsection to its own function to make the overall logic clearer.

BUG= 675776 
TEST=covered by existing tests

Review-Url: https://codereview.chromium.org/2629463002
Cr-Commit-Position: refs/heads/master@{#450528}

[modify] https://crrev.com/abcc1f5eb8bb22bd603342f951dbd076c8491d3b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/abcc1f5eb8bb22bd603342f951dbd076c8491d3b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

Comment 4 by rtoy@chromium.org, Feb 15 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment