New issue
Advanced search Search tips

Issue 675769 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 343579



Sign in to add a comment

Deprecate QUIC enum value from the client config proto

Project Member Reported by tbansal@chromium.org, Dec 19 2016

Issue description

Deprecate QUIC enum value from the client config proto since Chrome would never use a quic:// data reduction proxy. Instead, Chrome races a TLS connection with a QUIC connection when using a proxy that supports QUIC.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02

commit 88c417dfd4be5d9b22cbff9795a9ee3a2f081e02
Author: tbansal <tbansal@chromium.org>
Date: Tue Dec 20 02:17:36 2016

Store data reduction proxy server in a separate class

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG= 570435 ,671810,  675769 

Review-Url: https://codereview.chromium.org/2575323002
Cr-Commit-Position: refs/heads/master@{#439670}

[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/BUILD.gn
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[add] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_server.cc
[add] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_server.h
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc
[modify] https://crrev.com/88c417dfd4be5d9b22cbff9795a9ee3a2f081e02/components/data_reduction_proxy/proto/client_config.proto

Status: Fixed (was: Started)
Blocking: 343579

Sign in to add a comment