New issue
Advanced search Search tips

Issue 675765 link

Starred by 4 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up the icon size handling for PWAs

Project Member Reported by pkotw...@chromium.org, Dec 19 2016

Issue description

Clean up the icon size handling for PWAs
 
InstallableManager has two different minimum sizes on Android. The minimum size in ShortcutHelper#getMinimumHomescreenIconSizeInDp() was chosen by UX

The minimum size in InstallableManager::kIconMinimumSizeInPx is documented in https://developers.google.com/web/updates/2015/03/increasing-engagement-with-app-install-banners-in-chrome-for-android

Both minimum sizes are used in InstallableManager. This is very confusing
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499

commit 5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499
Author: zpeng <zpeng@chromium.org>
Date: Thu Jan 05 15:45:06 2017

Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

Originally patched from https://codereview.chromium.org/2589503002/.

BUG= 675765 

Review-Url: https://codereview.chromium.org/2611623003
Cr-Commit-Position: refs/heads/master@{#441659}

[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/banners/app_banner_manager_android.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/banners/app_banner_manager_android.h
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/manifest/manifest_icon_downloader.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/manifest/manifest_icon_downloader.h
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/manifest/manifest_icon_selector.cc
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/manifest/manifest_icon_selector.h
[modify] https://crrev.com/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499/chrome/browser/manifest/manifest_icon_selector_unittest.cc

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment