The data reduction proxy tamper detection code was used in an experiment that is no longer running. It should be removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cab2f1aefbb5d501bdd58018a64a6c010f3ddf6 commit 4cab2f1aefbb5d501bdd58018a64a6c010f3ddf6 Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Jul 06 18:33:01 2017 Remove tamper detection experiment code from data reduction proxy (DRP). Bug: 675761 Change-Id: Ic074688030e663ba996124f77ec9dc3b55cb23e0 Reviewed-on: https://chromium-review.googlesource.com/557988 Reviewed-by: Megan Jablonski <megjablon@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#484683} [modify] https://crrev.com/4cab2f1aefbb5d501bdd58018a64a6c010f3ddf6/components/data_reduction_proxy/core/browser/BUILD.gn [modify] https://crrev.com/4cab2f1aefbb5d501bdd58018a64a6c010f3ddf6/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc [delete] https://crrev.com/15ad36b93a803ce9b3da6f96ce971ac34e6f7f8c/components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.cc [delete] https://crrev.com/15ad36b93a803ce9b3da6f96ce971ac34e6f7f8c/components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.h [delete] https://crrev.com/15ad36b93a803ce9b3da6f96ce971ac34e6f7f8c/components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc [modify] https://crrev.com/4cab2f1aefbb5d501bdd58018a64a6c010f3ddf6/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4521a0a64f4fa7d5a023e3783d6a91ab4832d15 commit e4521a0a64f4fa7d5a023e3783d6a91ab4832d15 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Sep 12 22:28:52 2017 Remove some more tamper detection code from data reduction proxy The removed code is dead and unreachable since the tanper detection experiment is no longer enabled, and there are no plans to reenable that experiment. Bug: 675761 Change-Id: I70465d498111d15e01f6ea8fce784cd28cc8902f Reviewed-on: https://chromium-review.googlesource.com/663847 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501426} [modify] https://crrev.com/e4521a0a64f4fa7d5a023e3783d6a91ab4832d15/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc [modify] https://crrev.com/e4521a0a64f4fa7d5a023e3783d6a91ab4832d15/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc [modify] https://crrev.com/e4521a0a64f4fa7d5a023e3783d6a91ab4832d15/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc [modify] https://crrev.com/e4521a0a64f4fa7d5a023e3783d6a91ab4832d15/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h [modify] https://crrev.com/e4521a0a64f4fa7d5a023e3783d6a91ab4832d15/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5dcb8488883447904af5b68e0aa9c1d68d56508 commit c5dcb8488883447904af5b68e0aa9c1d68d56508 Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Nov 13 22:55:51 2017 Miscellaneous cleanups to the data reduction proxy * Remove some of the leftover tamper detection code * Add an explicit callback when a new client config is fetched * Limit the use of mock config for only the tests where it is actually required * Remove the deprecated mock call to the network quality estimator Bug: 760294 , 675761 Change-Id: Iaf8077e83bacca574aa6dea0ed9906f0d25d0176 Reviewed-on: https://chromium-review.googlesource.com/766072 Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#516088} [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h [modify] https://crrev.com/c5dcb8488883447904af5b68e0aa9c1d68d56508/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
Comment 1 by tbansal@chromium.org
, Jun 29 2017Status: Assigned (was: Available)