New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675738 link

Starred by 1 user
Status: Fixed
Owner:
█ ltian@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 650847



Sign in to add a comment

Custom search engines should always show the keyword

Project Member Reported by k...@chromium.org, Dec 19 2016 
Chrome version: Clank Dev

What steps will reproduce the problem?
(1) Visit Vine
(2) View search engine list in Settings

What is the expected result?

See keyword vine.co under Vine

What happens instead?

No keyword shows up.
Screenshot_20161219-135520.png
94.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0fdaeac4fcfad4d00ba10e10826ee375164e8db

commit a0fdaeac4fcfad4d00ba10e10826ee375164e8db
Author: ltian <ltian@chromium.org>
Date: Thu Dec 22 02:16:10 2016

[Android] Show keyword instead of parsed url for each custom engine

Currently Android displays "xxx.com" parsed from url of a TemplateURL. This
is not appropriate because url could ends with different types of
domains such as ".org", ".co" and etc. And also this is inconsitent with
information shown on desktop.

To solve this, the field will be displayed with the keyword of a
TemplateURL.

BUG= 675738 

Review-Url: https://codereview.chromium.org/2589013002
Cr-Commit-Position: refs/heads/master@{#440314}

[modify] https://crrev.com/a0fdaeac4fcfad4d00ba10e10826ee375164e8db/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
[modify] https://crrev.com/a0fdaeac4fcfad4d00ba10e10826ee375164e8db/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
[modify] https://crrev.com/a0fdaeac4fcfad4d00ba10e10826ee375164e8db/chrome/browser/search_engines/template_url_service_android.cc

Comment 2 by ltian@chromium.org, Dec 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment