New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675732 link

Starred by 1 user
Status: Fixed
Owner:
█ jamartin@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ twif...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Report precached resources once per download

Project Member Reported by jamartin@chromium.org, Dec 19 2016 
We currently report unused resources several times. This has limited use to us and, instead, we would like to know how many times a resource was actually downloaded from the network. This will allow us things like, for instance, have a meaningful ratio of used/downloaded per resource and host.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0

commit 02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0
Author: jamartin <jamartin@chromium.org>
Date: Wed Dec 21 19:26:46 2016

Report downloaded resources at most once

Before, we were reporting used_resources and unused_resources. used_resources was reported only once when the resource is used but unused_resources was reported on every single prefetch session for as long as the resource was still unused.

This change removes unused_resources and adds downloaded resources (with URL parameter d), which reports the "cost" of a resource once. This allows to have a meaningful ratio of used_resources / downloaded_resources.

BUG= 675732 

Review-Url: https://codereview.chromium.org/2586813004
Cr-Commit-Position: refs/heads/master@{#440176}

[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_database.cc
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_database.h
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_database_unittest.cc
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_fetcher.h
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_fetcher_unittest.cc
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_url_table.cc
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_url_table.h
[modify] https://crrev.com/02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0/components/precache/core/precache_url_table_unittest.cc

Comment 2 by bengr@chromium.org, Jan 3 2017

Status: Assigned (was: Untriaged)

Comment 3 by twif...@chromium.org, Jan 3 2017

Labels: Merge-Request-56

Comment 4 by dimu@chromium.org, Jan 3 2017

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c85e96f98e7d442b87e219fe0631c92b7c176b54

commit c85e96f98e7d442b87e219fe0631c92b7c176b54
Author: Devin Mullins <twifkak@google.com>
Date: Tue Jan 03 23:41:31 2017

Report downloaded resources at most once

Before, we were reporting used_resources and unused_resources. used_resources was reported only once when the resource is used but unused_resources was reported on every single prefetch session for as long as the resource was still unused.

This change removes unused_resources and adds downloaded resources (with URL parameter d), which reports the "cost" of a resource once. This allows to have a meaningful ratio of used_resources / downloaded_resources.

BUG= 675732 

Review-Url: https://codereview.chromium.org/2586813004
Cr-Commit-Position: refs/heads/master@{#440176}
(cherry picked from commit 02bf6c04e45ee64670eb9e6cd3a05c54d9a2eaa0)

Review-Url: https://codereview.chromium.org/2609323003 .
Cr-Commit-Position: refs/branch-heads/2924@{#659}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_database.cc
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_database.h
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_database_unittest.cc
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_fetcher.h
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_fetcher_unittest.cc
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_url_table.cc
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_url_table.h
[modify] https://crrev.com/c85e96f98e7d442b87e219fe0631c92b7c176b54/components/precache/core/precache_url_table_unittest.cc

Comment 6 by twif...@chromium.org, Jan 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment