New issue
Advanced search Search tips

Issue 675723 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove some duplicate string constants for Bluetooth chooser on Android

Project Member Reported by juncai@chromium.org, Dec 19 2016

Issue description

For the Bluetooth chooser string constants on Android,
IDS_BLUETOOTH_SEARCHING and IDS_BLUETOOTH_NOT_SEEING_IT are the same.
IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_NONE_FOUND and IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_SOME_FOUND are the same.

So can combine those duplicate strings.
 

Comment 1 by juncai@chromium.org, Dec 19 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d25e524393a0e3b568e42f62a1bf3cab32a0dd

commit 50d25e524393a0e3b568e42f62a1bf3cab32a0dd
Author: juncai <juncai@chromium.org>
Date: Tue Dec 27 21:15:38 2016

Remove duplicate string constants for Web Bluetooth chooser on Android

For the Web Bluetooth chooser string constants on Android,
IDS_BLUETOOTH_SEARCHING and IDS_BLUETOOTH_NOT_SEEING_IT are the same.
IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_NONE_FOUND and
IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_SOME_FOUND are the same.

This CL removes the duplicate strings.

BUG= 675723 

Review-Url: https://codereview.chromium.org/2590663002
Cr-Commit-Position: refs/heads/master@{#440789}

[modify] https://crrev.com/50d25e524393a0e3b568e42f62a1bf3cab32a0dd/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
[modify] https://crrev.com/50d25e524393a0e3b568e42f62a1bf3cab32a0dd/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/50d25e524393a0e3b568e42f62a1bf3cab32a0dd/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java

Comment 3 by juncai@chromium.org, Dec 27 2016

Status: Fixed (was: Started)

Sign in to add a comment