Bisect - android_perf_bisect_builder failing with unknown target chrome_modern_public_apk |
||||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.perf/builders/android_perf_bisect_builder?numbuilds=200 Last 100 or so builds have failed with this error: ninja: Entering directory `/b/build/slave/android_perf_bisect_builder/build/src/out/Release' ninja: error: unknown target 'chrome_modern_public_apk' step returned non-zero exit code: 1
,
Dec 19 2016
,
Dec 19 2016
This is probably due to N SDK update. Anything older than that will not work anymore. Simon - have you seen any builds/bisects that failed with this same error that were testing over revision ranges during that time? We're going to have to wontfix them if so.
,
Dec 19 2016
#1: Correct, chrome_modern_public_apk was added Nov 9: https://chromium.googlesource.com/chromium/src/+/be18d7c8226d8949d9b840a99b365e032697becf #3: per the above, this is not due to the N SDK.
,
Dec 19 2016
So should we just go ahead and build some generic "all" target and re-introduce these targets at a later date?
,
Dec 19 2016
I guess so, though all will be significantly slower.
,
Dec 20 2016
I don't know the exact number, but there seem to be a handful of regressions from pre-Nov 9 still being investigated, so maybe what we can do is: - Fix this for now by just building all (that's what it used to do anyway) - At some point in next few months switch back to building specific targets (or even get chromium_builder_perf working for android?), let perf sheriffs know this will happen and we won't be able to bisect older regressions, and WontFix the older regressions. What does everyone think?
,
Dec 20 2016
,
Dec 20 2016
benhenry: Can you help us figure out which regressions from before November 9 are most important to bisect?
,
Dec 20 2016
Looks like we have 149 alerts that are still open. I'm going to narrow this down more to see which don't need bisect and report back. https://bugs.chromium.org/p/chromium/issues/list?can=2&q=opened%3C2016-11-09+Performance%3DSheriff+Android&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids
,
Dec 20 2016
Here are 21 that would provide a decent value: https://bugs.chromium.org/p/chromium/issues/list?can=2&q=opened%3C2016-11-09+Performance%3DSheriff+Android+-has%3Aowner+modified%3E2016-12-01&sort=modified&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids The rest that I found are old, repeats, etc.
,
Dec 21 2016
https://bugs.chromium.org/p/chromium/issues/list?can=2&q=opened%3C2016-11-09+Performance%3DSheriff+Android+-has%3Aowner+modified%3E2016-12-01+-label%3ARestrict-View-Google&sort=modified&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids Brings this down to 9 Only the external android bots are affected by this.
,
Jan 5 2017
,
Jan 6 2017
Chatting offline w/ Annie/Dave, feeling here is that we can leave as is. If anybody pursues those we can revisit the "all" fix.
,
Feb 3 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by simonhatch@chromium.org
, Dec 19 2016