Adding missing attachments.

Deleted: password.png 33.2 KB

	password.png 33.2 KB View Download

Deleted: username.png 32.3 KB

	username.png 32.3 KB View Download

Screenshot of the fix at https://codereview.chromium.org/2585173006/

Deleted: Screenshot from 2016-12-19 12:55:36.png 61.7 KB

	Screenshot from 2016-12-19 12:55:36.png 61.7 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c97dee453dac00aaf5a24441a3a371efee1d43ef

commit c97dee453dac00aaf5a24441a3a371efee1d43ef
Author: estark <estark@chromium.org>
Date: Tue Dec 20 17:39:33 2016

Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG= 675696 
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Review-Url: https://codereview.chromium.org/2585173006
Cr-Commit-Position: refs/heads/master@{#439837}

[modify] https://crrev.com/c97dee453dac00aaf5a24441a3a371efee1d43ef/components/autofill_strings.grdp
[modify] https://crrev.com/c97dee453dac00aaf5a24441a3a371efee1d43ef/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/c97dee453dac00aaf5a24441a3a371efee1d43ef/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Why isn't the warning shown for 'username' fields if there isn't any autofill data stored for the field?

Re #5: the way the code is structured makes it hard to do that. Without stored autofill data, we don't know whether the field is a username field at the point that we add the Form-Not-Secure warning. There's a little bit of discussion on this in https://bugs.chromium.org/p/chromium/issues/detail?id=672663#c13.

I think we may be able to improve this in a future release. I'll file a bug to track that (will cc you).