I guess we would like to suggest no more than 4 billing addresses (include incomplete billing addresses if necessary) and list the complete addresses first. I am thinking shall we change text color or append something to indicate the address is incomplete?

Why not the same red "!" as used in the Card editor when there is no associated billing address?

Append the "phone required", "name required", etc? The same as billing address.

Let's run this by hwi@.

I think there's a benefit of having less items on the list. I'm wondering if we can provide suggestions on "new address editor(i.e. accessed via + add new address)" with existing profiles including incomplete addresses when the user starts typing in a field e.g. street address, similarly what we do on phone number field and email field. And then, behind the scene, we could merge incomplete profiles to complete profiles. 

> I'm wondering if we can provide suggestions on "new address editor(i.e. accessed via + add new address)" with existing profiles including incomplete addresses when the user starts typing in a field e.g. street address, similarly what we do on phone number field and email field.

Yes, that's possible.

hwi@: Should we be showing incomplete profiles in the billing address dropdown? We currently don't. If we do, selecting an incomplete billing address will launch the editor for it. Should we markup the incomplete billing address in the dropdown in any way? Two suggestions so far have been red (!) icon and "<Field-name> required" text.

re: c8

> Should we be showing incomplete profiles in the billing address dropdown?

Eligible 'incomplete' level might be: at least have data on the street name field, so items on the dropdown don't look so random but look like addresses. 

> "<Field-name> required" text

This approach seems to work better than red (i). Could you check if styling "<Field-name> required" in blue feasible? 

We could style the sub string as we did for payment address section (https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java?rcl=0&l=1369).

Hi Hwi@, get a draft version of appending tinted text for incomplete billing address in the billing address dropdown. Below are the screenshots.

The billing addresses in the dropdown are sorted by completeness.
Select incomplete address brings up address editor.
Select previously selected address or null if user cancels edition.
Select and add the newly added or edited address to the top of the dropdown if user finishes edition.

Deleted: Screenshot_2017-01-06-14-56-51.png 198 KB

	Screenshot_2017-01-06-14-56-51.png 198 KB View Download

Deleted: Screenshot_2017-01-06-14-56-59.png 126 KB

	Screenshot_2017-01-06-14-56-59.png 126 KB View Download

Great work!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928

commit 08b780f0ee9b1c60724ad8c8024bd84cc8a6d928
Author: gogerald <gogerald@chromium.org>
Date: Tue Jan 10 19:35:04 2017

List incomplete addresses in the billing address dropdown

The billing addresses in the dropdown contain edit required information
and are sorted by completeness.
Select incomplete address brings up address editor.
Select previously selected address or null if user cancels from address editor.
Select and add the newly added or completed address to the top of the dropdown.

BUG= 675686 

Review-Url: https://codereview.chromium.org/2614193002
Cr-Commit-Position: refs/heads/master@{#442657}

[modify] https://crrev.com/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
[modify] https://crrev.com/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
[modify] https://crrev.com/08b780f0ee9b1c60724ad8c8024bd84cc8a6d928/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8455c9126224dade8593d544baaf830f1cd58acc

commit 8455c9126224dade8593d544baaf830f1cd58acc
Author: gogerald <gogerald@chromium.org>
Date: Wed Jan 11 04:11:05 2017

Add compareBoolean for consistence

BUG= 675686 

Review-Url: https://codereview.chromium.org/2628463005
Cr-Commit-Position: refs/heads/master@{#442792}

[modify] https://crrev.com/8455c9126224dade8593d544baaf830f1cd58acc/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/8455c9126224dade8593d544baaf830f1cd58acc/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java