Flake: LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer |
||||
Issue descriptionBuilder Win7 Tests (dbg)(1), LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer flaked: LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #1): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (31 ms) LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #2): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (82 ms) LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #3): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (87 ms) LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #4): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (81 ms) see: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/55683
,
Feb 3 2017
danakj@, you seem to be the primary author of the test. Do you know what's going on here? (ie have you investigated this before?) Also, sorry if I'm misattributing the ownership since the changes might have been renames/refactors.
,
Feb 6 2017
Still Failing: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/57120 LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #1): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (48 ms) LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #2): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (34 ms) LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #3): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (34 ms) LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (run #4): [ RUN ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer c:\c\win\src\cc rees\layer_tree_host_unittest_copyrequest.cc(793): error: Value of: display_context_provider_->TestContext3d()->NumTextures() Actual: 63 Expected: num_textures_after_readback_ - 1 Which is: 64 [ FAILED ] LayerTreeHostCopyRequestTestDeleteTexture.RunSingleThread_DelegatingRenderer (34 ms)
,
Feb 9 2017
This is caused by the fact that copy requests cause a followup commit to remove the render surface. When the render surface goes away, a texture is destroyed in GLRenderer. And this races with the tasks posted by the test.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868 commit 6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868 Author: danakj <danakj@chromium.org> Date: Thu Feb 09 21:19:43 2017 Fix flaky LayerTreeHostCopyRequestTestDeleteTexture test. Because CopyOutputRequests make an extra RenderPass, which is backed by a texture, we do a follow-up draw to remove that texture. This raced with the texture counting that the test was doing. So wait for the draw before proceeding. R=vmpstr@chromium.org BUG= 675684 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2687143003 Cr-Commit-Position: refs/heads/master@{#449411} [modify] https://crrev.com/6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868/cc/resources/video_resource_updater_unittest.cc [modify] https://crrev.com/6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868/cc/test/test_gles2_interface.cc [modify] https://crrev.com/6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868/cc/test/test_web_graphics_context_3d.cc [modify] https://crrev.com/6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868/cc/test/test_web_graphics_context_3d.h [modify] https://crrev.com/6cd4cd4c30979c6fc520b090f1b64e3bcd1d0868/cc/trees/layer_tree_host_unittest_copyrequest.cc
,
Feb 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by loyso@chromium.org
, Jan 5 2017Labels: -OS-Windows OS-All
Status: Assigned (was: Untriaged)