New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675683 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MemoryInfra: Add more details about model type of sync data that is using memory

Project Member Reported by ssid@chromium.org, Dec 19 2016

Issue description

Background context:go/memory-infra: memory profiling in chrome://tracing

The sync dump provider shows only the total memory usage of the sync directory. It will be better if it tells if the memory is used by bookmarks or favicons or others.
 
Dmitry, would it be hard to do per-sync type breakdown in the memory dump provider?
Owner: dskiba@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by ssid@chromium.org, Dec 20 2016

Summary: MemoryInfra: Add more details about model type of sync data that is using memory (was: MemoryInfra: Add more details about what type of sync data is using memory)
GetModelTypeFromSpecifics() gives the model type.
Components: Internals>Instrumentation>Memory
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f48321e20afaa5ac2f11a2546cf33e791fe570

commit 65f48321e20afaa5ac2f11a2546cf33e791fe570
Author: dskiba <dskiba@chromium.org>
Date: Tue Jan 24 20:39:41 2017

[sync] Add model type counters to memory dumps.

crbug.com/675682 reported that in some rare cases sync uses enormous
amounts of memory. To correlate memory usage with size of user's profile,
this CL adds model type counters to memory dumps.

BUG= 675683 

Review-Url: https://codereview.chromium.org/2651563004
Cr-Commit-Position: refs/heads/master@{#445795}

[modify] https://crrev.com/65f48321e20afaa5ac2f11a2546cf33e791fe570/components/sync/syncable/directory.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ecd005e3a871cc9a4979c0a3ef822d9e7c0a787

commit 7ecd005e3a871cc9a4979c0a3ef822d9e7c0a787
Author: dskiba <dskiba@chromium.org>
Date: Thu Jan 26 17:51:34 2017

[tracing] Whitelist sync model type counters.

This CL whitelists model type counters that were added to the
sync MDP in crrev.com/2651563004.

BUG= 675683 

Review-Url: https://codereview.chromium.org/2655833003
Cr-Commit-Position: refs/heads/master@{#446373}

[modify] https://crrev.com/7ecd005e3a871cc9a4979c0a3ef822d9e7c0a787/base/trace_event/memory_infra_background_whitelist.cc

Comment 7 by ssid@chromium.org, Feb 7 2017

Labels: Memory-Slow-Reports

Comment 8 by dskiba@chromium.org, May 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment