New issue
Advanced search Search tips

Issue 675677 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 568901



Sign in to add a comment

Update main thread scrolling reason on subframes needed

Project Member Reported by yigu@chromium.org, Dec 19 2016

Issue description

After patch https://codereview.chromium.org/2531603003/, main thread scrolling reason becomes to frame based instead of page based. Therefore when setting the reason kHandlingScrollFromMainThread to a frame, all its subframes should be updated as well.
 

Comment 1 by yigu@chromium.org, Jan 12 2017

Status: WontFix (was: Assigned)
There is no need to update this reason to subframes.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21fc2f81007c4b950e49f817061aa7825577c812

commit 21fc2f81007c4b950e49f817061aa7825577c812
Author: yigu <yigu@chromium.org>
Date: Thu Jan 12 14:43:09 2017

When add main thread scrolling reason kHandlingScrolFromMainThread, there is no need to update the subframes as they are not scrollable when the reason is set to main frame.
BUG= 675677 

Review-Url: https://codereview.chromium.org/2620453003
Cr-Commit-Position: refs/heads/master@{#443228}

[modify] https://crrev.com/21fc2f81007c4b950e49f817061aa7825577c812/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp

Sign in to add a comment