New issue
Advanced search Search tips

Issue 675669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

[PR] The Contact Details doesn't update after the address editor exits.

Project Member Reported by ma...@chromium.org, Dec 19 2016

Issue description

If the user adds or edits a shipping address, the contact details section should update to reflect the new address (or the changes).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d8d2d7aab2598436338694558ac04c7de92b179

commit 7d8d2d7aab2598436338694558ac04c7de92b179
Author: mathp <mathp@chromium.org>
Date: Mon Jan 09 19:34:31 2017

[Payment Request] Update the Contacts section after editing address

Previous, a change to (or a new) shipping address would not update the
Contact Details section, resulting in the person having to re-enter their
details.

Now, when the address editor exits we add/replace the profile in the
collection and rebuild the Contact Details section.

BUG= 675669 
TEST=PaymentRequest*Shipping*

Review-Url: https://codereview.chromium.org/2590583002
Cr-Commit-Position: refs/heads/master@{#442311}

[modify] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[add] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java
[modify] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
[modify] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/android/java_sources.gni
[add] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsSectionUnitTest.java
[add] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/7d8d2d7aab2598436338694558ac04c7de92b179/chrome/test/data/android/payments/contact_details_and_free_shipping.js

Comment 2 by ma...@chromium.org, Jan 9 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment