vr shell error logging on starting |
||||||
Issue descriptionVrCoreVersionCheckerImpl logs a full exception stack back trace at error log level on every device that doesn't support VR when chrome starts. This is probably too verbose, since almost everywhere it is not expected to succeed. plus, the back trace doesn't add much anyway; the message only happens from one spot :) maybe a single log line, like "Unable to find compatible VrCore", reduced to info level would be enough. if VR is not enabled in about://flags, it might not need to to log anything. unsure if flags is available here, though, so maybe not a big deal. 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: Unable to find a compatible VrCore 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: com.google.vr.vrcore.base.api.VrCoreNotAvailableException: VR Service obsolete 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at com.google.vr.vrcore.base.api.VrCoreUtils.a(SourceFile:202) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at org.chromium.chrome.browser.vr_shell.VrCoreVersionCheckerImpl.isVrCoreCompatible(VrCoreVersionCheckerImpl.java:24) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at org.chromium.chrome.browser.vr_shell.VrShellDelegate.<init>(VrShellDelegate.java:1489) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at org.chromium.chrome.browser.ChromeTabbedActivity.postInflationStartup(ChromeTabbedActivity.java:980) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at org.chromium.chrome.browser.init.ChromeBrowserInitializer.handlePreNativeStartup(ChromeBrowserInitializer.java:144) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at org.chromium.chrome.browser.init.AsyncInitializationActivity.onCreate(AsyncInitializationActivity.java:4248) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.app.Activity.performCreate(Activity.java:6679) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1118) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2618) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2726) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.app.ActivityThread.-wrap12(ActivityThread.java) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1477) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.os.Handler.dispatchMessage(Handler.java:102) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.os.Looper.loop(Looper.java:154) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at android.app.ActivityThread.main(ActivityThread.java:6119) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at java.lang.reflect.Method.invoke(Native Method) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886) 12-19 10:39:38.205 13582 13582 E cr_VrCoreVersionChecker: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11f55eb73c8cb49cb171ba9b7b27bd605a386749 commit 11f55eb73c8cb49cb171ba9b7b27bd605a386749 Author: bshe <bshe@chromium.org> Date: Mon Dec 19 20:56:46 2016 Use info instead of error level log for non compatible VrCore BUG= 675663 Review-Url: https://codereview.chromium.org/2590443003 Cr-Commit-Position: refs/heads/master@{#439550} [modify] https://crrev.com/11f55eb73c8cb49cb171ba9b7b27bd605a386749/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
,
Dec 20 2016
Is this happening in M56 too? Should we merge this back?
,
Dec 20 2016
I think so. Requested merge.
,
Dec 20 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29592a2449a6c9b745fbe208ba34cd9d4514a33b commit 29592a2449a6c9b745fbe208ba34cd9d4514a33b Author: bshe <bshe@chromium.org> Date: Tue Dec 20 18:51:55 2016 Use info instead of error level log for non compatible VrCore BUG= 675663 Review-Url: https://codereview.chromium.org/2590443003 Cr-Commit-Position: refs/heads/master@{#439550} (cherry picked from commit 11f55eb73c8cb49cb171ba9b7b27bd605a386749) Review-Url: https://codereview.chromium.org/2590353002 . Cr-Commit-Position: refs/branch-heads/2924@{#564} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/29592a2449a6c9b745fbe208ba34cd9d4514a33b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java
,
Jan 3 2017
,
Feb 16 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bshe@chromium.org
, Dec 19 2016