Chrome should delete Last 1 pages when they are no longer valid |
|||||
Issue descriptionToday, we leave stale Last 1 pages lying around until cleaned up (potentially much later) making the model's API difficult to use for 3rd parties such as the NTP. We should: * Remove when the tab is closed by the user * Remove at startup after the tab list is populated.
,
Dec 22 2016
,
Jan 3 2017
Hi dewittj@, What is the current status of this bug? Does this fit before M57 FF or M57 BP? Have you considered using TabModelObserver? https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java?q=TabModelObserver
,
Jan 17 2017
Hi Justin, this is blocking our launch of the Recent Tabs section in M57. 8-O :) What are the prospects of this? Thanks Patrick
,
Jan 18 2017
Carlos mentioned today that M57 is very unlikely for the launch of Last 1 (which is a prerequisite for this bug). Dmitry and I are working on this right now, in the event that last 1 makes the cut.
,
Jan 18 2017
Heads up: on 19th we are going to turn off the feature on our side, if we do not get positive news from you.
,
Feb 21 2017
Hi, M58 BP is in 9 days, what is the current progress on this?
,
Mar 2 2017
I believe since https://codereview.chromium.org/2706343007 has been landed, this is now fixed?
,
Mar 4 2017
From the two ideas in the OP: * We are now deleting pages on tab closure after the CL referred in #8 landed. * At startup we clean up expired pages (last_n policy makes them expire after 2 days). This might be considered enough and then we can consider this fixed. But there's still room for improvement at startup where we could also delete extra snapshots for the same tab and snapshots of tabs that were closed.
,
Mar 15 2017
OK, let's fix this and open new bugs for the incremental improvements. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vitaliii@chromium.org
, Dec 20 2016