Issue metadata
Sign in to add a comment
|
PreCQ should build and run unit tests on a 32-bit x86 board |
||||||||||||||||||||||
Issue descriptionI'm not 100% sure how this is supposed to work, but I see that: https://chromium-review.googlesource.com/#/c/419733/ ...passed the PCQ and then failed the CQ on many boards: x86-zgb-paladin: The UnitTest stage failed: Packages failed in /mnt/host/source/chromite/bin/cros_run_unit_tests: chromeos-base/chromeos-login in https://luci-milo.appspot.com/buildbot/chromeos/x86-zgb-paladin/8493 x86-mario-paladin: The UnitTest stage failed: Packages failed in /mnt/host/source/chromite/bin/cros_run_unit_tests: chromeos-base/chromeos-login in https://luci-milo.appspot.com/buildbot/chromeos/x86-mario-paladin/12137 x86-mario-nowithdebug-paladin: The UnitTest stage failed: Packages failed in /mnt/host/source/chromite/bin/cros_run_unit_tests: chromeos-base/chromeos-login chromeos-base/chromite in https://luci-milo.appspot.com/buildbot/chromeos/x86-mario-nowithdebug-paladin/11639 x86-alex-paladin: The UnitTest stage failed: Packages failed in /mnt/host/source/chromite/bin/cros_run_unit_tests: chromeos-base/chromeos-login in https://luci-milo.appspot.com/buildbot/chromeos/x86-alex-paladin/26370 x86-generic-paladin: The UnitTest stage failed: Packages failed in /mnt/host/source/chromite/bin/cros_run_unit_tests: chromeos-base/chromeos-login in https://luci-milo.appspot.com/buildbot/chromiumos/x86-generic-paladin/28204 --- Maybe we should try to run those tests in the PCQ?
,
Dec 19 2016
Does anyone know how to see the failure? https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/11378 I just get: Luci login Error: 401 You are not authenticated, try logging in Request ID: 58582adb00ff0344eaf4ae3fd30001737e6c7563692d6d696c6f0001313331362d6466326439383300010103 luci, working for the Chromium project. Page built: Tue, 2016-12-20 11:45:47 AM (All times local)
,
Dec 19 2016
There should be a tiny login link (hidden in the upper-right corner, I think).
,
Dec 19 2016
OK, found it, thanks!
,
Dec 19 2016
The likely reason the PreCQ did not catch this as the PreCQ only runs on some boards. For this CL it ran on rambi and that did not exhibit the failure. But these older boards did however in the CQ proper.
,
Dec 19 2016
Thanks, Simran. This sounds like it's expected, then, unless there are plans to make the PCQ run on more boards.
,
Dec 19 2016
Aviv can comment on PCQ expansion to more boards, but I don't believe there are plans from my knowledge.
,
Dec 19 2016
It's pretty easy to add boards to the pre-cq set, or customize. In this case, it was run against rambi-pre-cq, mixed-a-pre-cq, mixed-b-pre-cq, and mixed-c-pre-cq. But for performance reasons, the only one of those that runs unit tests seems to be rambi-pre-cq. Here's the job that this CL ran in: https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/11236 I believe we limited the number of pre-cq configs that run unit test initially because we wanted to build out our gce fleet, and unit tests were rather slow on gce. But now we are running a lot more and beefier gce instances, so this may not be necessary anymore. +nxia for comment.
,
Dec 19 2016
just knew from here that we limited the unit tests on pre-cqs because of GCE performance. We should be able to get beefy gce instances to run unit tests, but pre-cqs with VMTests (like rambi-pre-cq) still need to run on physical machines, as the nesting feature hasn't been rolled out yet.
,
Jan 13 2017
Do we want to leave this bug open, or is it WontFix?
,
Jan 13 2017
We are currently using slower machines for the PreCQ (cros-standard-X vs cros-beefy-X). But it would be pretty easy to convert them to beefy.
,
Jan 13 2017
It seems like it may still be worthwhile doing to reduce failed CQ runs due to compilation errors.
,
Jan 13 2017
Agreed.
,
Jan 17 2017
,
Feb 8 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by derat@chromium.org
, Dec 19 2016