New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675633 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Themed inactive windows have wrong frame color

Project Member Reported by rsesek@chromium.org, Dec 19 2016

Issue description

Chrome Version: 57.0.2956.0
OS: macOS 10.12.2

What steps will reproduce the problem?
(1) Install https://chrome.google.com/webstore/detail/greyscale/olagifopidokilmoeiiejpmpfclmopfk
(2) Open a new window
(3) Switch away from chrome to make it inactive

What is the expected result?
Frame background color should be dark.

What happens instead?
Frame background color is white.

Please use labels and text to provide additional information.
You are probably looking for a change made after 439020 (known good), but no later than 439031 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/97c65878672508dea30c898fab48c40d36491589..550cea9c5d499321ed52150ece2108612cf66f9d

Likely https://chromium.googlesource.com/chromium/src/+/5afcb514af8ccd26ef17078957483f1be72bc592.

It looks like this was maybe intentional, except not on Mac? But there is a definite change on Mac.

See screen shots for difference.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
frame-actual.png
165 KB View Download
frame-expected.png
172 KB View Download

Comment 1 by bsep@chromium.org, Dec 19 2016

Cc: shrike@chromium.org
Status: WontFix (was: Assigned)
This was changed intentionally, see  bug 645682 . The short version is that themed frames now match the all-platform default frame colors, in terms of getting much lighter when inactive.

Comment 2 by shrike@chromium.org, Dec 19 2016

The idea was that when Chrome is running a custom theme, that that theme should use the same tinting logic on Mac as it does on other platforms (i.e. the theme should look the same no matter where you run it). That makes sense to me - rsesek@, what does that make sense to you?

Comment 3 by rsesek@chromium.org, Dec 20 2016

Yup, that does make sense.

Sign in to add a comment