New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 675629 link

Starred by 1 user
Status: Fixed
Owner:
█ mge...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Cronet crash in MaybeReportMetrics after exception in CronetUrlRequest.start()

Project Member Reported by mge...@chromium.org, Dec 19 2016 
When CronetUrlRequest.start() throws an exception, it destroys the native CronetURLRequestAdapter without first creating the net::URLRequest. MaybeReportMetrics() assumes that the URLRequest exists and crashes.

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7432bd7c942317b23e365d0a816891ba3e5e63f

commit c7432bd7c942317b23e365d0a816891ba3e5e63f
Author: mgersh <mgersh@chromium.org>
Date: Mon Dec 19 22:48:18 2016

Don't try to report metrics when there's no URLRequest

This case can happen when UrlRequest.start() throws an exception.

BUG= 675629 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2585203003
Cr-Commit-Position: refs/heads/master@{#439599}

[modify] https://crrev.com/c7432bd7c942317b23e365d0a816891ba3e5e63f/components/cronet/android/cronet_url_request_adapter.cc
[modify] https://crrev.com/c7432bd7c942317b23e365d0a816891ba3e5e63f/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Comment 3 by mge...@chromium.org, Dec 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment