New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675625 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove the QR Code scanner experiment code.

Project Member Reported by jif@chromium.org, Dec 19 2016

Issue description

This includes moving the code adding the force touch entry into the .plist listing the force touch actions.
 

Comment 1 by jif@chromium.org, Feb 1 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f067c6fa15e295d45c51946470567d5cd1baca3

commit 5f067c6fa15e295d45c51946470567d5cd1baca3
Author: jif <jif@chromium.org>
Date: Fri Feb 03 17:36:43 2017

Remove the iOS QR Code scanner experiment code.

This allows listing the QR Code scanner entry directly in the .plist listing the
force touch actions, as opposed to adding it at runtime,

BUG= 675625 

Review-Url: https://codereview.chromium.org/2676803002
Cr-Commit-Position: refs/heads/master@{#448016}

[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/application_delegate/user_activity_handler.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/application_delegate/user_activity_handler_unittest.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/resources/BUILD.gn
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/resources/Info.plist
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/resources/chrome_localize_strings_config.plist
[rename] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/resources/quick_action_qr_scanner@2x.png
[rename] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/resources/quick_action_qr_scanner@3x.png
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/app/spotlight/actions_spotlight_manager.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/app_startup_parameters.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/chrome_switches.cc
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/chrome_switches.h
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/resources/Settings.bundle/Experimental.plist
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/5f067c6fa15e295d45c51946470567d5cd1baca3/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
[delete] https://crrev.com/d262a0940e4985ed70f3954e9cf596adcf1b4a2a/ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/Contents.json

Cc: jasonkliu@chromium.org

Comment 4 by jif@chromium.org, Feb 6 2017

Labels: Merge-Request-57
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Hotlist-ConOps
Status: Verified (was: Fixed)
Verified 58.0.3005.0, iPhone7 plus iOS 10.2
Force touch entry is working fine
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93b8677d27b882fab26d18173748a54ff432110

commit a93b8677d27b882fab26d18173748a54ff432110
Author: Jean-François Geyelin <jif@google.com>
Date: Wed Feb 08 09:43:38 2017

Remove the iOS QR Code scanner experiment code.

This allows listing the QR Code scanner entry directly in the .plist listing the
force touch actions, as opposed to adding it at runtime,

BUG= 675625 

Review-Url: https://codereview.chromium.org/2676803002
Cr-Commit-Position: refs/heads/master@{#448016}
(cherry picked from commit 5f067c6fa15e295d45c51946470567d5cd1baca3)

Review-Url: https://codereview.chromium.org/2680263003 .
Cr-Commit-Position: refs/branch-heads/2987@{#382}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/application_delegate/user_activity_handler.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/application_delegate/user_activity_handler_unittest.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/resources/BUILD.gn
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/resources/Info.plist
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/resources/chrome_localize_strings_config.plist
[rename] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/resources/quick_action_qr_scanner@2x.png
[rename] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/resources/quick_action_qr_scanner@3x.png
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/app/spotlight/actions_spotlight_manager.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/app_startup_parameters.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/chrome_switches.cc
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/chrome_switches.h
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/resources/Settings.bundle/Experimental.plist
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/a93b8677d27b882fab26d18173748a54ff432110/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
[delete] https://crrev.com/b1b55fb2cf97a6274212b1f288ea20efff471901/ios/chrome/browser/ui/qr_scanner/resources/QRScanner.xcassets/quick_action_qr_scanner.imageset/Contents.json

Force touch is looking good on 57.0.2987.52 and 58.0.3012.0 on iPhone7 plus iOS 10.2
Verified the issue on the build 57.0.2987.53 beta tested on iPhone7+(iOS 10) and iPhone65+(iOS10)
QR scanner code works fine on 3Dforce touch,works fine

Sign in to add a comment