Remove default-page favicons for interstitials |
|||||
Issue descriptionWe currently show the default-page favicon for chrome://interstitials like security/privacy errors and captive portals. The empty-page favicon doesn't communicate anything useful to users and distracts from omnibox and content-area warnings. Removing the favicon would also make sense semantically since interstitials aren't website destinations (with favicon branding) from a user's perspective. This would be consistent with the new-tab page that doesn't show a favicon either.
,
Dec 27 2016
SGTM too, need to figure out how New Tab Page does it :)
,
Jan 11 2017
Adding omnibox component for tracking purposes.
,
Jan 11 2017
Don't have anything to add, but I think this is a good idea.
,
Jan 11 2017
meacer: You'll want to touch https://cs.chromium.org/chromium/src/chrome/browser/favicon/favicon_utils.cc?sq=package:chromium&dr=C&rcl=1484079984&l=48 .
,
Jan 11 2017
pkasting: Thanks! That just saved me from a lot of searching. A patch is at https://codereview.chromium.org/2624983002/
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/789e376399c0241ec76917af86c0b216791b6075 commit 789e376399c0241ec76917af86c0b216791b6075 Author: meacer <meacer@chromium.org> Date: Fri Jan 20 02:38:33 2017 Remove default-page favicon for interstitials This CL removes default favicon from interstitial pages. The check to do that needs to be done before checking the navigation entry, since interstitial navigations don't commit until the user proceeds through the interstitial. BUG= 675616 Review-Url: https://codereview.chromium.org/2624983002 Cr-Commit-Position: refs/heads/master@{#444957} [modify] https://crrev.com/789e376399c0241ec76917af86c0b216791b6075/chrome/browser/favicon/favicon_utils.cc
,
Jan 20 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by emilyschechter@chromium.org
, Dec 27 2016Components: UI>Browser>Interstitials