New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 675613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Make FLAKY EarlGrey test suite work upstream and downstream

Project Member Reported by baxley@chromium.org, Dec 19 2016

Issue description

The flaky suite looks for a specific target name, and only works downstream. This should be cleaned up so it works upstream and downstream.

We can probably use a substring search of the target name (e.g. "flaky_test_case"), so that it works with upstream and downstream flaky suites.
 

Comment 1 Deleted

Comment 2 Deleted

I've fixed it to only work with upstream target name.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/6189bf70457ca65820b5df510f0125d1148967f7

commit 6189bf70457ca65820b5df510f0125d1148967f7
Author: baxley <baxley@google.com>
Date: Fri Dec 23 01:28:35 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b457f0ab9dac0e67cab0b84134999a1c6b0d5e40

commit b457f0ab9dac0e67cab0b84134999a1c6b0d5e40
Author: baxley <baxley@chromium.org>
Date: Fri Jan 13 02:19:24 2017

Create suffix to run more than one flaky EarlGrey target.

Allow there to be multiple suites that run on the flaky bot, since
we have more than one test suite. Use the appendix "_flaky_egtests"
to denote targets. Previously it only ran "ios_chrome_flaky_egtests".

BUG= 675613 

Review-Url: https://codereview.chromium.org/2629733002
Cr-Commit-Position: refs/heads/master@{#443468}

[modify] https://crrev.com/b457f0ab9dac0e67cab0b84134999a1c6b0d5e40/ios/chrome/test/earl_grey/chrome_test_case.mm

Status: Fixed (was: Assigned)

Sign in to add a comment