New issue
Advanced search Search tips

Issue 675597 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cleanup authpolicy dbus client

Project Member Reported by rsorokin@chromium.org, Dec 19 2016

Issue description

Switch to OnceCallback
Check response type (if it's an error).
 
Components: Enterprise
Labels: Enterprise-Triaged
Labels: OS-Chrome
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/630dcb3a25341206e66d3cae8cef4182273511dc

commit 630dcb3a25341206e66d3cae8cef4182273511dc
Author: rsorokin <rsorokin@chromium.org>
Date: Thu Jan 19 16:54:34 2017

Check error returned from RefreshPolicy calls

BUG= 675597 
TEST=none

Review-Url: https://codereview.chromium.org/2640323002
Cr-Commit-Position: refs/heads/master@{#444767}

[modify] https://crrev.com/630dcb3a25341206e66d3cae8cef4182273511dc/chromeos/dbus/auth_policy_client.cc

Comment 5 by tnagel@chromium.org, Jan 31 2017

Labels: CodeHealth
Labels: -M-58 M-59
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c46c166645ad80352881e692745cd2c30aa24f

commit d8c46c166645ad80352881e692745cd2c30aa24f
Author: rsorokin <rsorokin@chromium.org>
Date: Tue Apr 11 08:43:19 2017

Add AuthPolicyLoginHelper

Allows cancel all pending calls and restart AuthPolicy service. Used
for enrollment and login UI to proper cancel the flows.

Also
Add RestartAuthPolicyService into UpstartClient.
Make UI flows properly cancel pending authpolicy operations.
Add delays in the FakeAuthPolicy clients in JoinAdDomain and
Authenticate user calls.
Move writing password piping into the AuthPolicyLoginHelper.

BUG= 677487 , 662400 , 676337 , 675597 
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2794493002
Cr-Commit-Position: refs/heads/master@{#463578}

[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/BUILD.gn
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client_unittest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_upstart_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_upstart_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/upstart_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/upstart_client.h
[add] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/login/auth/authpolicy_login_helper.cc
[add] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/login/auth/authpolicy_login_helper.h

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment