New issue
Advanced search Search tips

Issue 675594 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Scroll gestures should flash overlay scrollbars regardless of whether the page scrolls

Project Member Reported by bokan@chromium.org, Dec 19 2016

Issue description

Currently, we only show overlay scrollbars once the page/scroller actually changes position. There's concern this might prevent users from being able to discover horizontal content so we should show the scrollbars when a scroll event occurs, regardless of whether it causes a real scroll.
 

Comment 1 by bokan@chromium.org, Dec 21 2016

Cc: bokan@chromium.org
Labels: -Pri-3 Pri-2
Owner: chaopeng@chromium.org
Status: Started (was: Assigned)
Status: Assigned (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2b25bd2d961354db5081b6090d3782c10513fab

commit b2b25bd2d961354db5081b6090d3782c10513fab
Author: chaopeng <chaopeng@chromium.org>
Date: Mon Mar 13 20:52:51 2017

Show Overlay Scrollbar when GestureScrollUpdate

Currently, we only show overlay scrollbars once the page/scroller actually
changes position. In this patch, I also call the
WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
 show scrollbar when we receive scroll gestures.

BUG= 675594 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2611013002
Cr-Commit-Position: refs/heads/master@{#456474}

[modify] https://crrev.com/b2b25bd2d961354db5081b6090d3782c10513fab/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/b2b25bd2d961354db5081b6090d3782c10513fab/cc/input/scrollbar_animation_controller.h
[modify] https://crrev.com/b2b25bd2d961354db5081b6090d3782c10513fab/cc/input/scrollbar_animation_controller_unittest.cc
[modify] https://crrev.com/b2b25bd2d961354db5081b6090d3782c10513fab/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/b2b25bd2d961354db5081b6090d3782c10513fab/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/b2b25bd2d961354db5081b6090d3782c10513fab/cc/trees/layer_tree_impl.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7a846538699afcb05ba89a8dd8abbf5bbc418ab

commit c7a846538699afcb05ba89a8dd8abbf5bbc418ab
Author: chaopeng <chaopeng@chromium.org>
Date: Thu Mar 16 03:16:08 2017

Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10 id:260001 of https://codereview.chromium.org/2611013002/ )

Reason for revert:
memory regression:  crbug.com/701810 

Original issue's description:
> Show Overlay Scrollbar when GestureScrollUpdate
>
> Currently, we only show overlay scrollbars once the page/scroller actually
> changes position. In this patch, I also call the
> WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
>  show scrollbar when we receive scroll gestures.
>
> BUG= 675594 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2611013002
> Cr-Commit-Position: refs/heads/master@{#456474}
> Committed: https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3782c10513fab

TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 675594 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2748343004
Cr-Commit-Position: refs/heads/master@{#457334}

[modify] https://crrev.com/c7a846538699afcb05ba89a8dd8abbf5bbc418ab/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/c7a846538699afcb05ba89a8dd8abbf5bbc418ab/cc/input/scrollbar_animation_controller.h
[modify] https://crrev.com/c7a846538699afcb05ba89a8dd8abbf5bbc418ab/cc/input/scrollbar_animation_controller_unittest.cc
[modify] https://crrev.com/c7a846538699afcb05ba89a8dd8abbf5bbc418ab/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/c7a846538699afcb05ba89a8dd8abbf5bbc418ab/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/c7a846538699afcb05ba89a8dd8abbf5bbc418ab/cc/trees/layer_tree_impl.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fddbf72985cda9f23f0416c6e6eb1c7714825656

commit fddbf72985cda9f23f0416c6e6eb1c7714825656
Author: chaopeng <chaopeng@chromium.org>
Date: Thu Mar 23 14:24:33 2017

Reland of Show Overlay Scrollbar when GestureScrollUpdate (patchset #2 id:160001 of https://codereview.chromium.org/2748343004/ )

Fix for GPU memory issue:
This issue is caused by more than one DelayedFadeOut task posted.
So we cancel the previous task before we post a new one.

Original issue's description:
> Revert of Show Overlay Scrollbar when GestureScrollUpdate (patchset #10 id:260001 of https://codereview.chromium.org/2611013002/ )
>
> Reason for revert:
> memory regression:  crbug.com/701810 
>
> Original issue's description:
> > Show Overlay Scrollbar when GestureScrollUpdate
> >
> > Currently, we only show overlay scrollbars once the page/scroller actually
> > changes position. In this patch, I also call the
> > WillUpdateScroll(rename from DidScrollUpdate) when GestureScrollUpdate so we can
> >  show scrollbar when we receive scroll gestures.
> >
> > BUG= 675594 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> >
> > Review-Url: https://codereview.chromium.org/2611013002
> > Cr-Commit-Position: refs/heads/master@{#456474}
> > Committed: https://chromium.googlesource.com/chromium/src/+/b2b25bd2d961354db5081b6090d3782c10513fab
>
> TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 675594 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2748343004
> Cr-Commit-Position: refs/heads/master@{#457334}
> Committed: https://chromium.googlesource.com/chromium/src/+/c7a846538699afcb05ba89a8dd8abbf5bbc418ab

TBR=weiliangc@chromium.org,bokan@chromium.org,pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 675594 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2770733002
Cr-Commit-Position: refs/heads/master@{#459077}

[modify] https://crrev.com/fddbf72985cda9f23f0416c6e6eb1c7714825656/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/fddbf72985cda9f23f0416c6e6eb1c7714825656/cc/input/scrollbar_animation_controller.h
[modify] https://crrev.com/fddbf72985cda9f23f0416c6e6eb1c7714825656/cc/input/scrollbar_animation_controller_unittest.cc
[modify] https://crrev.com/fddbf72985cda9f23f0416c6e6eb1c7714825656/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/fddbf72985cda9f23f0416c6e6eb1c7714825656/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/fddbf72985cda9f23f0416c6e6eb1c7714825656/cc/trees/layer_tree_impl.cc

Status: Verified (was: Fixed)
9460.34.0, 59.0.3071.47

Comment 9 by bokan@chromium.org, May 15 2017

Cc: est...@chromium.org sgabr...@chromium.org
 Issue 676106  has been merged into this issue.

Sign in to add a comment