run_gpu_integration_test.py doesn't always properly pass --js-flags along |
|||
Issue descriptionE.g.: This one shows tracing: python content/test/gpu/run_gpu_integration_test.py webgl_conformance --show-stdout --browser=release -v --extra-browser-args="--js-flags=\"--trace-gc --trace-incremental-marking\" " --webgl-conformance-version=2.0.1 --test-filter=WebglConformance_deqp_functional_gles3_clipping If we add one more flag, the tracing info is gone: python content/test/gpu/run_gpu_integration_test.py webgl_conformance --show-stdout --browser=release -v --extra-browser-args="--js-flags=\"--trace-gc --trace-incremental-marking --use-allocation-folding\" " --webgl-conformance-version=2.0.1 --test-filter=WebglConformance_deqp_functional_gles3_clipping We've had a similar issue with telemetry about ~1 year ago. Since this has been resolved in telemetry, any chance this is using an old runner? It's making debugging quite hard because we cannot trust the flags anymore but have to recompile to be sure that something is enabled.
,
Dec 20 2016
I observed this on Windows, yes. I already reported this in 521560, which got fast initial responses and then didn't see much love :)
,
Jan 4 2017
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25da6356a3246812d79aaedcb236e1545ed88c95 commit 25da6356a3246812d79aaedcb236e1545ed88c95 Author: kbr <kbr@chromium.org> Date: Wed Jan 04 18:15:03 2017 Support --js-flags via --extra-browser-args in WebGL conformance tests. It's impractical to merge them, so instead, allow overriding them. Tested manually on Windows. BUG= 675582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2617453002 Cr-Commit-Position: refs/heads/master@{#441410} [modify] https://crrev.com/25da6356a3246812d79aaedcb236e1545ed88c95/content/test/gpu/gpu_tests/webgl_conformance_integration_test.py
,
Jan 4 2017
This is fixed for this particular test suite above. I don't know how to fix this more generally for the perf tests (Issue 521560), but if there are any other gpu_integration_tests with this problem, please file a new bug and I'll generalize the fix. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kbr@chromium.org
, Dec 20 2016Components: Tests>Telemetry
Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)