Issue 675577 link

Starred by 1 user

Issue metadata

Status:	Assigned
Owner:	rohitrao@chromium.org
Cc:	█ noyau@chromium.org sdefresne@chromium.org rohitrao@chromium.org ios-bugs@chromium.org █ ramyan@chromium.org
Components:	UI>Browser>Mobile>Share UI>Browser>NewTabPage UI>Browser>Omnibox UI>Browser>Toolbar
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Bug
Hotlist-Metrics

Upstreaming followup: add action names to tools/metrics/actions/actions.xml

Project Member Reported by sdefresne@chromium.org, Dec 19 2016

Issue description

Presubmit warning when upstreaming ios/ code:

File ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm line 139: MobileGALInstallInfoBarLinkNavigation is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.
File ios/chrome/browser/ui/activity_services/activity_type_util.mm line 136: MobileShareMenuUnknown is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.
File ios/chrome/browser/ui/browser_view_controller.mm line 3389: MobileToolbarPageSecurityInfo is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.
File ios/chrome/browser/ui/ntp/google_landing_controller.mm line 817: MobileNTPMostVisitedVoiceSearch is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.
File ios/chrome/browser/ui/omnibox/omnibox_popup_view_ios.mm line 294: MobileOmniboxClipboardToURL is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.
File ios/chrome/browser/ui/settings/native_apps_collection_view_controller.mm line 104: MobileGALOpenSettings is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.
File ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm line 493: MobileTabSwitcherPresented is missing in tools/metrics/actions/actions.xml. Please run tools/metrics/actions/extract_actions.py to update.

Comment 1 by sdefresne@chromium.org, Dec 19 2016

Cc: noyau@chromium.org

noyau: those are followup to upstreaming work.

Some of them can already be addressed now (UMA histograms and actions.xml). If you want, please feel free to split in smaller issues and assign them to owners.