Issue 675576 link

Starred by 1 user

Issue metadata

Status:	Assigned
Owner:	rohitrao@chromium.org
Cc:	█ noyau@chromium.org sdefresne@chromium.org rohitrao@chromium.org skare@chromium.org isherman@chromium.org ios-bugs@chromium.org asvitk...@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Task
Hotlist-Metrics

Upstreaming followup: add histograms to tools/metrics/histograms/histograms.xml

Project Member Reported by sdefresne@chromium.org, Dec 19 2016

Issue description

Presubmit warning when upstreaming ios/ code:

Some UMA_HISTOGRAM lines have been modified and the associated histogram name has no match in either tools/metrics/histograms/histograms.xml or the modifications of it:
   [ios/chrome/app/application_delegate/metrics_mediator.mm:101] Startup.ColdStartWithExternalURLTime \
   [ios/chrome/app/application_delegate/metrics_mediator.mm:103] Startup.ColdStartWithoutExternalURLTime \
   [ios/chrome/app/application_delegate/metrics_mediator.mm:337] MemoryWarning.OccurrencesPerSession \
   [ios/chrome/app/application_delegate/url_opener.mm:50] FirstRun.LaunchSource \
   [ios/chrome/app/application_delegate/user_activity_handler.mm:70] IOS.Handoff.Origin \
   [ios/chrome/app/application_delegate/user_activity_handler.mm:95] IOS.Spotlight.Origin \
   [ios/chrome/app/spotlight/bookmarks_spotlight_manager.mm:331] IOS.Spotlight.BookmarksInitialIndexSize \
   [ios/chrome/app/spotlight/spotlight_util.mm:175] IOS.Spotlight.Availability \
   [ios/chrome/browser/crash_report/crash_restore_helper.mm:217] TabRestore.error_remove_backup_at_path \
   [ios/chrome/browser/crash_report/crash_restore_helper.mm:235] TabRestore.error_remove_session_at_path \
   [ios/chrome/browser/metrics/size_class_recorder.mm:38] Tab.HorizontalSizeClassUsed \
   [ios/chrome/browser/metrics/size_class_recorder.mm:107] Tab.PageLoadInHorizontalSizeClass \
   [ios/chrome/browser/tabs/tab.mm:1479] Tab.PageLoadInPortrait \
   [ios/chrome/browser/tabs/tab.mm:1483] Tab.PageLoadInPortrait \
   [ios/chrome/browser/tabs/tab_model.mm:699] Session.ClosedTabCounts \
   [ios/chrome/browser/tabs/tab_model.mm:701] Session.OpenedTabCounts \
   [ios/chrome/browser/tabs/tab_model.mm:703] Session.NewTabCounts \
   [ios/chrome/browser/ui/first_run/first_run_util.mm:111] FirstRun.SignIn \
   [ios/chrome/browser/ui/settings/native_apps_collection_view_controller.mm:356] NativeAppLauncher.Settings \
   [ios/chrome/browser/ui/stack_view/stack_view_controller.mm:953] MemoryWarning.OccurredDuringCardStackSession \
   [ios/chrome/browser/web/external_app_launcher.mm:47] Tab.ExternalApplicationOpened

Comment 1 by sdefresne@chromium.org, Dec 19 2016

Cc: noyau@chromium.org

noyau: those are followup to upstreaming work.

Some of them can already be addressed now (UMA histograms and actions.xml). If you want, please feel free to split in smaller issues and assign them to owners.